From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 92F8E293B; Fri, 25 Jan 2019 13:45:02 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1C5DCDF86; Fri, 25 Jan 2019 12:45:01 +0000 (UTC) Received: from localhost (unknown [10.40.205.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 601EA600D7; Fri, 25 Jan 2019 12:44:55 +0000 (UTC) Date: Fri, 25 Jan 2019 13:44:45 +0100 From: Jens Freimann To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , "Michael S . Tsirkin" , Tiwei Bie , Zhihong Wang , stable@dpdk.org Message-ID: <20190125124445.ttat7tihaaq3p5b5@jenstp.localdomain> References: <20190124165902.24178-1-i.maximets@samsung.com> <20190124165902.24178-4-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190124165902.24178-4-i.maximets@samsung.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 25 Jan 2019 12:45:01 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 12:45:02 -0000 On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote: >Read barrier is required between reading the flags (desc_is_used) >and the content of descriptor to ensure the ordering. >Otherwise, speculative read of desc.id could be reordered with >reading of the desc.flags. > >Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") >Cc: stable@dpdk.org > >Signed-off-by: Ilya Maximets >--- > drivers/net/virtio/virtio_rxtx.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Jens Freimann