From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2DCD61B45D for ; Thu, 31 Jan 2019 16:50:09 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 89A47CA377; Thu, 31 Jan 2019 15:50:08 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-200.ams2.redhat.com [10.36.117.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F7D55C207; Thu, 31 Jan 2019 15:50:07 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: dpdk stable Date: Thu, 31 Jan 2019 15:48:28 +0000 Message-Id: <20190131154901.5383-20-ktraynor@redhat.com> In-Reply-To: <20190131154901.5383-1-ktraynor@redhat.com> References: <20190131154901.5383-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 31 Jan 2019 15:50:08 +0000 (UTC) Subject: [dpdk-stable] patch 'mem: fix storing old policy' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 15:50:09 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From ea3ae1eefd27e5bc6111fc0aa1959bd189ebe97a Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 8 Jan 2019 16:46:28 +0000 Subject: [PATCH] mem: fix storing old policy [ upstream commit ba07193e0343680ae5665efd45ecc41c0ec0059d ] The original code was supposed to overwrite the value pointed to by the pointer, but the new one is instead overwriting the pointer value itself, which has no effect outside that function. Fix it by adding a pointer dereference. Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c index 10b176d09..f63d9ca66 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c @@ -177,5 +177,5 @@ prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id) "Failed to get current mempolicy: %s. " "Assuming MPOL_DEFAULT.\n", strerror(errno)); - oldpolicy = MPOL_DEFAULT; + *oldpolicy = MPOL_DEFAULT; } RTE_LOG(DEBUG, EAL, -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-31 15:44:06.217641017 +0000 +++ 0020-mem-fix-storing-old-policy.patch 2019-01-31 15:44:05.000000000 +0000 @@ -1,15 +1,16 @@ -From ba07193e0343680ae5665efd45ecc41c0ec0059d Mon Sep 17 00:00:00 2001 +From ea3ae1eefd27e5bc6111fc0aa1959bd189ebe97a Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 8 Jan 2019 16:46:28 +0000 Subject: [PATCH] mem: fix storing old policy +[ upstream commit ba07193e0343680ae5665efd45ecc41c0ec0059d ] + The original code was supposed to overwrite the value pointed to by the pointer, but the new one is instead overwriting the pointer value itself, which has no effect outside that function. Fix it by adding a pointer dereference. Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") -Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov --- @@ -17,7 +18,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c -index 5b421f1d7..b6fb183db 100644 +index 10b176d09..f63d9ca66 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c @@ -177,5 +177,5 @@ prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id)