From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1A5271B456 for ; Thu, 31 Jan 2019 16:50:36 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3859AC0B201A; Thu, 31 Jan 2019 15:50:35 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-200.ams2.redhat.com [10.36.117.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71CC65C21F; Thu, 31 Jan 2019 15:50:33 +0000 (UTC) From: Kevin Traynor To: Julien Meunier Cc: Xiao Wang , dpdk stable Date: Thu, 31 Jan 2019 15:48:38 +0000 Message-Id: <20190131154901.5383-30-ktraynor@redhat.com> In-Reply-To: <20190131154901.5383-1-ktraynor@redhat.com> References: <20190131154901.5383-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 31 Jan 2019 15:50:35 +0000 (UTC) Subject: [dpdk-stable] patch 'net/fm10k: fix internal switch initial status' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 15:50:36 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 35234c648c24823524900c82202d6716c63f5599 Mon Sep 17 00:00:00 2001 From: Julien Meunier Date: Wed, 2 Jan 2019 17:57:45 +0200 Subject: [PATCH] net/fm10k: fix internal switch initial status [ upstream commit 04018a4552e630a2c019bade0c6b5f822aded0c1 ] sm_down is a boolean in order to check if the internal switch of the fm10k is up or down. This variable is configured though an interrupt by fm10k_dev_interrupt_handler_pf. If sm_down is uninitialized, we are not sure of its value at the first bring up. For example, if FM10K_EICR_SWITCHREADY is raised, the PMD will try to reconfigure the switch, but it does not make sense, as it's the first startup. The sm_down implementation has been introduced commit 6c9f37245583 ("net/fm10k: support switch restart on PF"). Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") Signed-off-by: Julien Meunier Acked-by: Xiao Wang --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 85fb6c5cb..caf4d1bc0 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -3004,4 +3004,5 @@ fm10k_params_init(struct rte_eth_dev *dev) info->rx_vec_allowed = true; + info->sm_down = false; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-31 15:44:06.445861170 +0000 +++ 0030-net-fm10k-fix-internal-switch-initial-status.patch 2019-01-31 15:44:05.000000000 +0000 @@ -1,8 +1,10 @@ -From 04018a4552e630a2c019bade0c6b5f822aded0c1 Mon Sep 17 00:00:00 2001 +From 35234c648c24823524900c82202d6716c63f5599 Mon Sep 17 00:00:00 2001 From: Julien Meunier Date: Wed, 2 Jan 2019 17:57:45 +0200 Subject: [PATCH] net/fm10k: fix internal switch initial status +[ upstream commit 04018a4552e630a2c019bade0c6b5f822aded0c1 ] + sm_down is a boolean in order to check if the internal switch of the fm10k is up or down. This variable is configured though an interrupt by fm10k_dev_interrupt_handler_pf. @@ -16,7 +18,6 @@ commit 6c9f37245583 ("net/fm10k: support switch restart on PF"). Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") -Cc: stable@dpdk.org Signed-off-by: Julien Meunier Acked-by: Xiao Wang