From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 012F61B459 for ; Thu, 31 Jan 2019 16:50:48 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 487BEB0802; Thu, 31 Jan 2019 15:50:47 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-200.ams2.redhat.com [10.36.117.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D63B5C23E; Thu, 31 Jan 2019 15:50:45 +0000 (UTC) From: Kevin Traynor To: Cristian Dumitrescu Cc: Bernard Iremonger , dpdk stable Date: Thu, 31 Jan 2019 15:48:44 +0000 Message-Id: <20190131154901.5383-36-ktraynor@redhat.com> In-Reply-To: <20190131154901.5383-1-ktraynor@redhat.com> References: <20190131154901.5383-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 31 Jan 2019 15:50:47 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix quit to stop all ports before close' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 15:50:48 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From ca1931382bce5246f06bc5514ea972d9b021723b Mon Sep 17 00:00:00 2001 From: Cristian Dumitrescu Date: Fri, 4 Jan 2019 12:28:33 +0000 Subject: [PATCH] app/testpmd: fix quit to stop all ports before close [ upstream commit 08fd782b8454ab9019290d35f4e5334b4235923e ] This patch proposes a slightly different test-pmd quit operation: stop all devices before starting to close any device. Basically, stop all moving parts before beginning to remove them. The current test-pmd quit is stopping and closing each device before moving to the next device. If all devices in the system are independent of each other, this difference is usually not important. In case of Soft NIC devices, any such virtual device typically depends on one or more physical devices being alive, as it accesses their queues, so this difference becomes important. Without this straightforward fix, all the Soft NIC devices need to be manually stopped before the quit command is issued, otherwise the quit command can sometimes crash the test-pmd application. Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") Signed-off-by: Cristian Dumitrescu Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4c75587d0..7b0c8e682 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2407,7 +2407,11 @@ pmd_test_exit(void) no_link_check = 1; RTE_ETH_FOREACH_DEV(pt_id) { - printf("\nShutting down port %d...\n", pt_id); + printf("\nStopping port %d...\n", pt_id); fflush(stdout); stop_port(pt_id); + } + RTE_ETH_FOREACH_DEV(pt_id) { + printf("\nShutting down port %d...\n", pt_id); + fflush(stdout); close_port(pt_id); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-31 15:44:06.586619948 +0000 +++ 0036-app-testpmd-fix-quit-to-stop-all-ports-before-close.patch 2019-01-31 15:44:05.000000000 +0000 @@ -1,8 +1,10 @@ -From 08fd782b8454ab9019290d35f4e5334b4235923e Mon Sep 17 00:00:00 2001 +From ca1931382bce5246f06bc5514ea972d9b021723b Mon Sep 17 00:00:00 2001 From: Cristian Dumitrescu Date: Fri, 4 Jan 2019 12:28:33 +0000 Subject: [PATCH] app/testpmd: fix quit to stop all ports before close +[ upstream commit 08fd782b8454ab9019290d35f4e5334b4235923e ] + This patch proposes a slightly different test-pmd quit operation: stop all devices before starting to close any device. Basically, stop all moving parts before beginning to remove them. The current test-pmd quit @@ -19,7 +21,6 @@ command can sometimes crash the test-pmd application. Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") -Cc: stable@dpdk.org Signed-off-by: Cristian Dumitrescu Acked-by: Bernard Iremonger @@ -28,10 +29,10 @@ 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c -index 8d584b008..15a948828 100644 +index 4c75587d0..7b0c8e682 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c -@@ -2392,7 +2392,11 @@ pmd_test_exit(void) +@@ -2407,7 +2407,11 @@ pmd_test_exit(void) no_link_check = 1; RTE_ETH_FOREACH_DEV(pt_id) { - printf("\nShutting down port %d...\n", pt_id);