From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 603F11B459 for ; Thu, 31 Jan 2019 16:50:49 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BFE0B7AEAF; Thu, 31 Jan 2019 15:50:48 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-200.ams2.redhat.com [10.36.117.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88C4C5C26A; Thu, 31 Jan 2019 15:50:47 +0000 (UTC) From: Kevin Traynor To: Declan Doherty Cc: dpdk stable Date: Thu, 31 Jan 2019 15:48:45 +0000 Message-Id: <20190131154901.5383-37-ktraynor@redhat.com> In-Reply-To: <20190131154901.5383-1-ktraynor@redhat.com> References: <20190131154901.5383-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 31 Jan 2019 15:50:48 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bonding: fix possible null pointer reference' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 15:50:49 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From bd4ccb020058a258f7bb76b1495aeee5694cd51c Mon Sep 17 00:00:00 2001 From: Declan Doherty Date: Tue, 8 Jan 2019 11:17:56 +0000 Subject: [PATCH] net/bonding: fix possible null pointer reference [ upstream commit e6b8757bb72caa565d24282ad8e405f28e3a34a9 ] In function check_for_bonded_ethdev the driver name is used without validating the pointer references in the passed ethdev object. Fixes: 740feaf349b1 ("ethdev: remove driver name from device private data") Signed-off-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_api.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 21bcd5044..e5e146540 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -20,5 +20,8 @@ check_for_bonded_ethdev(const struct rte_eth_dev *eth_dev) { /* Check valid pointer */ - if (eth_dev->device->driver->name == NULL) + if (eth_dev == NULL || + eth_dev->device == NULL || + eth_dev->device->driver == NULL || + eth_dev->device->driver->name == NULL) return -1; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-31 15:44:06.610730007 +0000 +++ 0037-net-bonding-fix-possible-null-pointer-reference.patch 2019-01-31 15:44:05.000000000 +0000 @@ -1,13 +1,14 @@ -From e6b8757bb72caa565d24282ad8e405f28e3a34a9 Mon Sep 17 00:00:00 2001 +From bd4ccb020058a258f7bb76b1495aeee5694cd51c Mon Sep 17 00:00:00 2001 From: Declan Doherty Date: Tue, 8 Jan 2019 11:17:56 +0000 Subject: [PATCH] net/bonding: fix possible null pointer reference +[ upstream commit e6b8757bb72caa565d24282ad8e405f28e3a34a9 ] + In function check_for_bonded_ethdev the driver name is used without validating the pointer references in the passed ethdev object. Fixes: 740feaf349b1 ("ethdev: remove driver name from device private data") -Cc: stable@dpdk.org Signed-off-by: Declan Doherty ---