patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jens Freimann <jfreimann@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com, maxime.coquelin@redhat.com,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [v3] net/virtio: set offload flag for jumbo frames
Date: Thu, 31 Jan 2019 17:33:25 +0100	[thread overview]
Message-ID: <20190131163325.glu2x7nqogn4d5y7@jenstp.localdomain> (raw)
In-Reply-To: <2cb3d89b-5fe4-735c-2dc9-62ba49d305f2@samsung.com>

On Thu, Jan 31, 2019 at 02:01:53PM +0300, Ilya Maximets wrote:
>On 31.01.2019 12:17, Jens Freimann wrote:
>> Port configuration fails because offload flags don't match the expected
>> value when max-pkt-len is set to a value that should enable receive port
>> offloading but doesn't.
>>
>> There are two cases to consider:
>>
>> 1. VIRTIO_NET_F_MTU is set. Then we need to check if the requested
>>    max-pkt-len fits into the MTU plus header. If yes we set the
>>    offload flag.
>> 2. VIRTIO_NET_F_MTU is not set. We can set the offload flag.
>>
>> Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> v2->v3:
>>  * remove unnecessary brackets (Maxime)
>>  * fix commit message (David)
>>
>> v1->v2:
>>  * include virtnet hdr, ethernet header, vlan tag when comparing against
>>    max-rx-pkt-len (Maxime)
>>
>>  drivers/net/virtio/virtio_ethdev.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>> index 7c4c1df00..f39d4e630 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -2351,6 +2351,20 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>  	if ((host_features & tso_mask) == tso_mask)
>>  		dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO;
>>
>> +	if (host_features & (1ULL << VIRTIO_NET_F_MTU)) {
>> +		struct virtio_net_config config;
>> +		uint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN +
>> +			hw->vtnet_hdr_size;
>> +		vtpci_read_dev_config(hw,
>> +				offsetof(struct virtio_net_config, mtu),
>> +				&config.mtu, sizeof(config.mtu));
>> +		if (dev->data->dev_conf.rxmode.max_rx_pkt_len <=
>> +				config.mtu + ether_hdr_len)
>> +			dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>> +	} else {
>> +		dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>> +	}
>> +
>
>Why we can't just use 'hw->max_mtu' here for checking instead of
>reading 'config.mtu' ?
>Also, It's already calculated with regards to VIRTIO_NET_F_MTU.

Can't mtu have changed after device init? If not then yes, I guess we
could use hw->max_mtu.

regards,
Jens

      reply	other threads:[~2019-01-31 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  9:17 [dpdk-stable] [PATCH v3] " Jens Freimann
2019-01-31  9:28 ` Maxime Coquelin
     [not found] ` <CGME20190131110154eucas1p150b171c1c77a49e12843d28b61116966@eucas1p1.samsung.com>
2019-01-31 11:01   ` [dpdk-stable] [v3] " Ilya Maximets
2019-01-31 16:33     ` Jens Freimann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131163325.glu2x7nqogn4d5y7@jenstp.localdomain \
    --to=jfreimann@redhat.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).