From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 00EFB1B50F for ; Thu, 7 Feb 2019 14:27:42 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32F8750A08; Thu, 7 Feb 2019 13:27:41 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08E99649DD; Thu, 7 Feb 2019 13:27:39 +0000 (UTC) From: Kevin Traynor To: Jiayu Hu Cc: Konstantin Ananyev , dpdk stable Date: Thu, 7 Feb 2019 13:25:27 +0000 Message-Id: <20190207132614.20538-21-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 07 Feb 2019 13:27:41 +0000 (UTC) Subject: [dpdk-stable] patch 'doc: add GRO limitations in programmers guide' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:27:42 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From f31db6a62d113c999a2b1db6e234cffb65350077 Mon Sep 17 00:00:00 2001 From: Jiayu Hu Date: Wed, 16 Jan 2019 10:13:42 +0800 Subject: [PATCH] doc: add GRO limitations in programmers guide [ upstream commit 5bd5f7b3aee8d0d9cef658c47c7f7544e657ae96 ] This patch adds GRO limitations in the programmer guide. Fixes: 2c900d09055e ("doc: add GRO guide") Signed-off-by: Jiayu Hu Acked-by: Konstantin Ananyev --- .../generic_receive_offload_lib.rst | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/prog_guide/generic_receive_offload_lib.rst b/doc/guides/prog_guide/generic_receive_offload_lib.rst index 9c6a4d08c..5b3fb91c8 100644 --- a/doc/guides/prog_guide/generic_receive_offload_lib.rst +++ b/doc/guides/prog_guide/generic_receive_offload_lib.rst @@ -192,2 +192,21 @@ Header fields deciding if packets are neighbors include: Additionally, packets which have different value of DF bit can't be merged. + +GRO Library Limitations +----------------------- + +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ + outer_l3_len/packet_type to get protocol headers for the + input packet, rather than parsing the packet header. Therefore, + before call GRO APIs to merge packets, user applications + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/ + packet_type to the same values as the protocol headers of the + packet. + +- GRO library doesn't support to process the packets with IPv4 + Options or VLAN tagged. + +- GRO library just supports to process the packet organized + in a single MBUF. If the input packet consists of multiple + MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are + unknown. -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.016060600 +0000 +++ 0021-doc-add-GRO-limitations-in-programmers-guide.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,12 +1,13 @@ -From 5bd5f7b3aee8d0d9cef658c47c7f7544e657ae96 Mon Sep 17 00:00:00 2001 +From f31db6a62d113c999a2b1db6e234cffb65350077 Mon Sep 17 00:00:00 2001 From: Jiayu Hu Date: Wed, 16 Jan 2019 10:13:42 +0800 Subject: [PATCH] doc: add GRO limitations in programmers guide +[ upstream commit 5bd5f7b3aee8d0d9cef658c47c7f7544e657ae96 ] + This patch adds GRO limitations in the programmer guide. Fixes: 2c900d09055e ("doc: add GRO guide") -Cc: stable@dpdk.org Signed-off-by: Jiayu Hu Acked-by: Konstantin Ananyev