From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 10BD01B513 for ; Thu, 7 Feb 2019 14:27:45 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DBDD77F76D; Thu, 7 Feb 2019 13:27:43 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB6D9690E8; Thu, 7 Feb 2019 13:27:42 +0000 (UTC) From: Kevin Traynor To: Yanglong Wu Cc: Qi Zhang , dpdk stable Date: Thu, 7 Feb 2019 13:25:29 +0000 Message-Id: <20190207132614.20538-23-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 07 Feb 2019 13:27:44 +0000 (UTC) Subject: [dpdk-stable] patch 'net/i40e: fix VF overwrite PF RSS LUT for X722' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:27:45 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From b7b11844a8b20b39a74ae239b85acc7e2e412056 Mon Sep 17 00:00:00 2001 From: Yanglong Wu Date: Tue, 15 Jan 2019 10:23:45 +0800 Subject: [PATCH] net/i40e: fix VF overwrite PF RSS LUT for X722 [ upstream commit 1d4b2b4966bbb219afd2d7072ffba51f3a3067a5 ] i40e_aq_set_rss_lut should set register according to the vsi->type. if not, VF may overwrite the rigister of PF. Note, only X722 is impacted, since flag I40E_FLAG_RSS_AQ_CAPABLE is only enabled on X722. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Signed-off-by: Yanglong Wu Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index a6b97e164..f97cd5348 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4184,5 +4184,6 @@ i40e_get_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size) if (pf->flags & I40E_FLAG_RSS_AQ_CAPABLE) { - ret = i40e_aq_get_rss_lut(hw, vsi->vsi_id, TRUE, + ret = i40e_aq_get_rss_lut(hw, vsi->vsi_id, + vsi->type != I40E_VSI_SRIOV, lut, lut_size); if (ret) { @@ -4223,5 +4224,6 @@ i40e_set_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size) if (pf->flags & I40E_FLAG_RSS_AQ_CAPABLE) { - ret = i40e_aq_set_rss_lut(hw, vsi->vsi_id, TRUE, + ret = i40e_aq_set_rss_lut(hw, vsi->vsi_id, + vsi->type != I40E_VSI_SRIOV, lut, lut_size); if (ret) { -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.061923492 +0000 +++ 0023-net-i40e-fix-VF-overwrite-PF-RSS-LUT-for-X722.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From 1d4b2b4966bbb219afd2d7072ffba51f3a3067a5 Mon Sep 17 00:00:00 2001 +From b7b11844a8b20b39a74ae239b85acc7e2e412056 Mon Sep 17 00:00:00 2001 From: Yanglong Wu Date: Tue, 15 Jan 2019 10:23:45 +0800 Subject: [PATCH] net/i40e: fix VF overwrite PF RSS LUT for X722 +[ upstream commit 1d4b2b4966bbb219afd2d7072ffba51f3a3067a5 ] + i40e_aq_set_rss_lut should set register according to the vsi->type. if not, VF may overwrite the rigister of PF. @@ -10,7 +12,6 @@ is only enabled on X722. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") -Cc: stable@dpdk.org Signed-off-by: Yanglong Wu Acked-by: Qi Zhang