From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 141611B54D for ; Thu, 7 Feb 2019 14:27:49 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63F406772B; Thu, 7 Feb 2019 13:27:48 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F872690E1; Thu, 7 Feb 2019 13:27:46 +0000 (UTC) From: Kevin Traynor To: Andrew Rybchenko Cc: dpdk stable Date: Thu, 7 Feb 2019 13:25:32 +0000 Message-Id: <20190207132614.20538-26-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Feb 2019 13:27:48 +0000 (UTC) Subject: [dpdk-stable] patch 'net/sfc: fix VF error/missed stats mapping' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:27:49 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 76e8d658e8250200bd2410a18328cf2f8e25f342 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Wed, 16 Jan 2019 09:43:23 +0000 Subject: [PATCH] net/sfc: fix VF error/missed stats mapping [ upstream commit 24f8a95917b36b313a49bd604c3958f992893efd ] VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed packet because of overflow. VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions, but mainly impossibility to deliver because of no descriptors available, so it is better to classify it as imissed. Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 3886daf7a..9f59c8db9 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -538,6 +538,5 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) mac_stats[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]; - stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_OVERFLOW]; - stats->ierrors = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; + stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; stats->oerrors = mac_stats[EFX_MAC_VADAPTER_TX_BAD_PACKETS]; } else { -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.147688785 +0000 +++ 0026-net-sfc-fix-VF-error-missed-stats-mapping.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From 24f8a95917b36b313a49bd604c3958f992893efd Mon Sep 17 00:00:00 2001 +From 76e8d658e8250200bd2410a18328cf2f8e25f342 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Wed, 16 Jan 2019 09:43:23 +0000 Subject: [PATCH] net/sfc: fix VF error/missed stats mapping +[ upstream commit 24f8a95917b36b313a49bd604c3958f992893efd ] + VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed packet because of overflow. @@ -11,7 +13,6 @@ available, so it is better to classify it as imissed. Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") -Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko ---