From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8E5131B50F for ; Thu, 7 Feb 2019 14:28:14 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAAE417FC13; Thu, 7 Feb 2019 13:28:13 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3060600D7; Thu, 7 Feb 2019 13:28:12 +0000 (UTC) From: Kevin Traynor To: Harman Kalra Cc: Remy Horton , dpdk stable Date: Thu, 7 Feb 2019 13:25:48 +0000 Message-Id: <20190207132614.20538-42-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Feb 2019 13:28:13 +0000 (UTC) Subject: [dpdk-stable] patch 'test/metrics: fix a negative case' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:14 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 6423daae9b4b22ec966d702ab83a556968e01ea9 Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Mon, 10 Dec 2018 08:39:15 +0000 Subject: [PATCH] test/metrics: fix a negative case [ upstream commit 99f16073b2a3d9881aa8fabe24c62834d902afda ] Negative test case for passing invalid count size to rte_metrics_update_values() will pass if count value is any value greater than 1 because set size wrt to key id 1 is 1 and passing 0 as no of values to be updated will not hit the ERANGE check. Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library") Signed-off-by: Harman Kalra Acked-by: Remy Horton --- test/test/test_metrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_metrics.c b/test/test/test_metrics.c index 94d54d71c..3c2f36b8a 100644 --- a/test/test/test_metrics.c +++ b/test/test/test_metrics.c @@ -155,5 +155,5 @@ test_metrics_update_values(void) /* Failed Test: Invalid count size */ err = rte_metrics_update_values(RTE_METRICS_GLOBAL, - KEY, &value[0], 0); + KEY, &value[0], ARRAY_SIZE(value)); TEST_ASSERT(err < 0, "%s, %d", __func__, __LINE__); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.524208234 +0000 +++ 0042-test-metrics-fix-a-negative-case.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From 99f16073b2a3d9881aa8fabe24c62834d902afda Mon Sep 17 00:00:00 2001 +From 6423daae9b4b22ec966d702ab83a556968e01ea9 Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Mon, 10 Dec 2018 08:39:15 +0000 Subject: [PATCH] test/metrics: fix a negative case +[ upstream commit 99f16073b2a3d9881aa8fabe24c62834d902afda ] + Negative test case for passing invalid count size to rte_metrics_update_values() will pass if count value is any value greater than 1 because set size wrt to @@ -10,7 +12,6 @@ updated will not hit the ERANGE check. Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library") -Cc: stable@dpdk.org Signed-off-by: Harman Kalra Acked-by: Remy Horton