From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E1BEC1B544 for ; Thu, 7 Feb 2019 14:28:24 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50EBE432D4; Thu, 7 Feb 2019 13:28:24 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55F2A600C4; Thu, 7 Feb 2019 13:28:23 +0000 (UTC) From: Kevin Traynor To: Ilya Maximets Cc: Anatoly Burakov , dpdk stable Date: Thu, 7 Feb 2019 13:25:56 +0000 Message-Id: <20190207132614.20538-50-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Feb 2019 13:28:24 +0000 (UTC) Subject: [dpdk-stable] patch 'eal/linux: fix parsing zero socket memory and limits' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:25 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 0122564d8c372d879aa9848675d54dfaa933d464 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Tue, 22 Jan 2019 19:27:14 +0300 Subject: [PATCH] eal/linux: fix parsing zero socket memory and limits [ upstream commit 0a703f0f36c11b6f23fad4fab9e79c308811329d ] Modern memory mode allowes to not reserve any memory by the '--socket-mem' option. i.e. it could be possible to specify zero preallocated memory like '--socket-mem 0'. Also, it should be possible to configure unlimited memory allocations by '--socket-limit 0'. Both cases are impossible now and blocks starting the DPDK application: ./dpdk-app --socket-limit 0 <...> EAL: invalid parameters for --socket-limit EAL: Invalid 'command line' arguments. Unable to initialize DPDK: Invalid argument Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") Signed-off-by: Ilya Maximets Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 0226b7f6a..30138b638 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -582,8 +582,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) } - /* check if we have a positive amount of total memory */ - if (total_mem == 0) - return -1; - return 0; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.735202710 +0000 +++ 0050-eal-linux-fix-parsing-zero-socket-memory-and-limits.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From 0a703f0f36c11b6f23fad4fab9e79c308811329d Mon Sep 17 00:00:00 2001 +From 0122564d8c372d879aa9848675d54dfaa933d464 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Tue, 22 Jan 2019 19:27:14 +0300 Subject: [PATCH] eal/linux: fix parsing zero socket memory and limits +[ upstream commit 0a703f0f36c11b6f23fad4fab9e79c308811329d ] + Modern memory mode allowes to not reserve any memory by the '--socket-mem' option. i.e. it could be possible to specify zero preallocated memory like '--socket-mem 0'. @@ -18,7 +20,6 @@ Unable to initialize DPDK: Invalid argument Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") -Cc: stable@dpdk.org Signed-off-by: Ilya Maximets Acked-by: Anatoly Burakov @@ -27,10 +28,10 @@ 1 file changed, 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c -index a386829f3..13f401684 100644 +index 0226b7f6a..30138b638 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c -@@ -583,8 +583,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) +@@ -582,8 +582,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) } - /* check if we have a positive amount of total memory */