From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CB3CB1B526 for ; Thu, 7 Feb 2019 14:28:26 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A104A0213; Thu, 7 Feb 2019 13:28:26 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9ACF6620DE; Thu, 7 Feb 2019 13:28:24 +0000 (UTC) From: Kevin Traynor To: Ilya Maximets Cc: Shuai Zhu , David Marchand , Anatoly Burakov , dpdk stable Date: Thu, 7 Feb 2019 13:25:57 +0000 Message-Id: <20190207132614.20538-51-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Feb 2019 13:28:26 +0000 (UTC) Subject: [dpdk-stable] patch 'test: check zero socket memory as valid' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:27 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 2e0185e8a962790f4adda67c9a3e6f9465fb6677 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Fri, 25 Jan 2019 10:55:58 +0300 Subject: [PATCH] test: check zero socket memory as valid [ upstream commit 10d66cee5bf51bbd27d58b565b3340282e18ef07 ] Dynamic memory mode allowes zero socket-mem because all the required memory could be allocated on demand. Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits") Reported-by: Shuai Zhu Signed-off-by: Ilya Maximets Reviewed-by: David Marchand Acked-by: Anatoly Burakov --- test/test/test_eal_flags.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c index e3a60c7ae..81e345b87 100644 --- a/test/test/test_eal_flags.c +++ b/test/test/test_eal_flags.c @@ -1159,5 +1159,5 @@ test_memory_flags(void) "--file-prefix=" memtest, "-m", DEFAULT_MEM_SIZE}; - /* invalid (zero) --socket-mem flag */ + /* valid (zero) --socket-mem flag */ const char *argv2[] = {prgname, "-c", "10", "-n", "2", "--file-prefix=" memtest, "--socket-mem=0,0,0,0"}; @@ -1257,6 +1257,6 @@ test_memory_flags(void) return -1; } - if (launch_proc(argv2) == 0) { - printf("Error - process run ok with invalid (zero) --socket-mem!\n"); + if (launch_proc(argv2) != 0) { + printf("Error - process failed with valid (zero) --socket-mem!\n"); return -1; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.758409525 +0000 +++ 0051-test-check-zero-socket-memory-as-valid.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,13 +1,14 @@ -From 10d66cee5bf51bbd27d58b565b3340282e18ef07 Mon Sep 17 00:00:00 2001 +From 2e0185e8a962790f4adda67c9a3e6f9465fb6677 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Fri, 25 Jan 2019 10:55:58 +0300 Subject: [PATCH] test: check zero socket memory as valid +[ upstream commit 10d66cee5bf51bbd27d58b565b3340282e18ef07 ] + Dynamic memory mode allowes zero socket-mem because all the required memory could be allocated on demand. Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits") -Cc: stable@dpdk.org Reported-by: Shuai Zhu Signed-off-by: Ilya Maximets