patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Wei Zhao <wei.zhao1@intel.com>
Cc: Yuan Peng <yuan.peng@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/i40e: fix queue region DCB configure' has been queued to LTS release 18.11.1
Date: Thu,  7 Feb 2019 13:25:58 +0000	[thread overview]
Message-ID: <20190207132614.20538-52-ktraynor@redhat.com> (raw)
In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From bff4efdafb86e4e54a08cb806ba72d5dd78f6fa3 Mon Sep 17 00:00:00 2001
From: Wei Zhao <wei.zhao1@intel.com>
Date: Tue, 22 Jan 2019 16:11:03 +0800
Subject: [PATCH] net/i40e: fix queue region DCB configure

[ upstream commit 991a2e812fcfdba6d47b77462e06859262def583 ]

DCB is not necessary to be configured if no user priority of
queue region is requested.

Unexpected configuration of DCB will cause unexpected behavior, like
FDIR does not work on those queues, but could cause more issues.

Fixes: 7cbecc2f7424 ("net/i40e: support queue region set and flush")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Yuan Peng <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/rte_pmd_i40e.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index 7ce5d02fa..c49c872b6 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -2819,5 +2819,5 @@ i40e_queue_region_dcb_configure(struct i40e_hw *hw,
 	int32_t ret = -EINVAL;
 	uint16_t i, j, prio_index, region_index;
-	uint8_t tc_map, tc_bw, bw_lf;
+	uint8_t tc_map, tc_bw, bw_lf, dcb_flag = 0;
 
 	if (!info->queue_region_number) {
@@ -2826,4 +2826,14 @@ i40e_queue_region_dcb_configure(struct i40e_hw *hw,
 	}
 
+	for (i = 0; i < info->queue_region_number; i++) {
+		if (info->region[i].user_priority_num) {
+			dcb_flag = 1;
+			break;
+		}
+	}
+
+	if (dcb_flag == 0)
+		return 0;
+
 	dcb_cfg = &dcb_cfg_local;
 	memset(dcb_cfg, 0, sizeof(struct i40e_dcbx_config));
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-02-07 13:19:56.782142122 +0000
+++ 0052-net-i40e-fix-queue-region-DCB-configure.patch	2019-02-07 13:19:55.000000000 +0000
@@ -1,8 +1,10 @@
-From 991a2e812fcfdba6d47b77462e06859262def583 Mon Sep 17 00:00:00 2001
+From bff4efdafb86e4e54a08cb806ba72d5dd78f6fa3 Mon Sep 17 00:00:00 2001
 From: Wei Zhao <wei.zhao1@intel.com>
 Date: Tue, 22 Jan 2019 16:11:03 +0800
 Subject: [PATCH] net/i40e: fix queue region DCB configure
 
+[ upstream commit 991a2e812fcfdba6d47b77462e06859262def583 ]
+
 DCB is not necessary to be configured if no user priority of
 queue region is requested.
 
@@ -10,7 +12,6 @@
 FDIR does not work on those queues, but could cause more issues.
 
 Fixes: 7cbecc2f7424 ("net/i40e: support queue region set and flush")
-Cc: stable@dpdk.org
 
 Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
 Tested-by: Yuan Peng <yuan.peng@intel.com>

  parent reply	other threads:[~2019-02-07 13:28 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 13:25 [dpdk-stable] patch 'net/mlx5: remove checks for outer tunnel items on E-Switch' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: validate tunnel inner " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: support " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: validate ethernet type " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: support ethernet type for tunnels " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: fix typos and code style' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/enic: remove useless include' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'drivers: fix sprintf with snprintf' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal: fix log level of error in option register' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: fix a typo in power management guide' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'test/hash: fix perf result' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'examples/tep_term: remove unused constant' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'examples/vhost: fix a typo' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal: fix core number validation' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal: fix out of bound access when no CPU available' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal: check string parameter lengths' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal: fix clang build with intrinsics forced' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'build: fix meson check for binutils 2.30' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'app/pdump: fix vdev cleanup' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'gro: check invalid TCP header length' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: add GRO limitations in programmers guide' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'examples/kni: fix crash while handling userspace request' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/i40e: fix VF overwrite PF RSS LUT for X722' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: fix Rx packet padding' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/mlx5: fix deprecated library API for Rx " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/sfc: fix VF error/missed stats mapping' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/sfc: fix datapath name references in logs' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'vhost: fix memory leak on realloc failure' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'examples/vhost: fix path allocation failure handling' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/sfc: fix Rx packets counter' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: fix ifc naming' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: add missing loopback option in testpmd guide' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'efd: fix tail queue leak' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'bus/ifpga: fix build for cpp applications' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'bus/ifpga: fix forcing optional devargs' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'bus/ifpga: fix AFU probe failure handler' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'raw/ifpga: fix memory leak' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/qede: fix performance bottleneck in Rx path' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'net/qede: remove prefetch in Tx " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: fix references in power management guide' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'doc: add GCM AAD limitation in qat " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'test/metrics: fix a negative case' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'vfio: allow secondary process to query IOMMU type' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'ethdev: fix errno to have positive value' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'gso: fix VxLAN/GRE tunnel checks' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'kni: fix build on RHEL8 for arm and Power9' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'kni: fix build for dev_open in Linux 5.0' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'kni: fix build for igb_ndo_bridge_setlink " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'vfio: fix error message' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'eal/linux: fix parsing zero socket memory and limits' " Kevin Traynor
2019-02-07 13:25 ` [dpdk-stable] patch 'test: check zero socket memory as valid' " Kevin Traynor
2019-02-07 13:25 ` Kevin Traynor [this message]
2019-02-07 13:25 ` [dpdk-stable] patch 'vhost: fix access for indirect descriptors' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/sfc: fix crash in EF10 TSO if no payload' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'app/testpmd: fix Tx metadata show command' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/virtio-user: fix used ring in cvq handling' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/mlx5: fix TC rule handle assignment' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/mlx5: fix VXLAN port registration race condition' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/i40e: fix statistics' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/sfc: fix port ID log' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/mlx5: fix VXLAN without decap action for E-Switch' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/ena: fix dev init with multi-process' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/ena: fix errno to positive value' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'crypto/qat: fix digest in wireless auth case' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'build: mention -march in pkg-config description' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'doc: add dependency for PDF in contributing guide' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'net/mlx5: fix build for armv8' " Kevin Traynor
2019-02-07 13:26 ` [dpdk-stable] patch 'doc: clarify libnuma requirement for NUMA systems' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207132614.20538-52-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).