From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 238551B524 for ; Thu, 7 Feb 2019 14:28:35 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 856D144BCC; Thu, 7 Feb 2019 13:28:34 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A917600D7; Thu, 7 Feb 2019 13:28:33 +0000 (UTC) From: Kevin Traynor To: Dekel Peled Cc: Ferruh Yigit , dpdk stable Date: Thu, 7 Feb 2019 13:26:01 +0000 Message-Id: <20190207132614.20538-55-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Feb 2019 13:28:34 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix Tx metadata show command' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:35 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 3830f48513ff1568b81f9b3d694444e0766c8b4f Mon Sep 17 00:00:00 2001 From: Dekel Peled Date: Tue, 22 Jan 2019 17:16:43 +0200 Subject: [PATCH] app/testpmd: fix Tx metadata show command [ upstream commit 5ffbd70b1712d1856aa86f18877628b2d94813ce ] Function cmd_config_tx_metadata_specific_parsed() takes input value, applies rte_cpu_to_be_32() on it, and stores it for Tx use. Function cmd_show_tx_metadata_parsed() displays the stored value as is. This patch modifies function cmd_show_tx_metadata_parsed(), to apply rte_be_to_cpu_32() on the stored value before displaying it. Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item") Signed-off-by: Dekel Peled Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 3ddc3e02a..51704b500 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -18456,5 +18456,5 @@ cmd_show_tx_metadata_parsed(void *parsed_result, if (!strcmp(res->cmd_keyword, "tx_metadata")) { printf("Port %u tx_metadata: %u\n", res->cmd_pid, - ports[res->cmd_pid].tx_metadata); + rte_be_to_cpu_32(ports[res->cmd_pid].tx_metadata)); } } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:56.855713177 +0000 +++ 0055-app-testpmd-fix-Tx-metadata-show-command.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From 5ffbd70b1712d1856aa86f18877628b2d94813ce Mon Sep 17 00:00:00 2001 +From 3830f48513ff1568b81f9b3d694444e0766c8b4f Mon Sep 17 00:00:00 2001 From: Dekel Peled Date: Tue, 22 Jan 2019 17:16:43 +0200 Subject: [PATCH] app/testpmd: fix Tx metadata show command +[ upstream commit 5ffbd70b1712d1856aa86f18877628b2d94813ce ] + Function cmd_config_tx_metadata_specific_parsed() takes input value, applies rte_cpu_to_be_32() on it, and stores it for Tx use. Function cmd_show_tx_metadata_parsed() displays the stored value as is. @@ -11,7 +13,6 @@ rte_be_to_cpu_32() on the stored value before displaying it. Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item") -Cc: stable@dpdk.org Signed-off-by: Dekel Peled Reviewed-by: Ferruh Yigit