From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 055A71B3B5 for ; Thu, 7 Feb 2019 14:28:46 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62EC789AE1; Thu, 7 Feb 2019 13:28:45 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B0DD600C4; Thu, 7 Feb 2019 13:28:44 +0000 (UTC) From: Kevin Traynor To: Michal Krawczyk Cc: dpdk stable Date: Thu, 7 Feb 2019 13:26:09 +0000 Message-Id: <20190207132614.20538-63-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Feb 2019 13:28:45 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ena: fix errno to positive value' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:46 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From b1c6319021c04f2032ceb0de0eb3b7cab3063365 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Fri, 25 Jan 2019 09:10:26 +0100 Subject: [PATCH] net/ena: fix errno to positive value [ upstream commit baeed5f404dd1b049118cfec26a2fd3203671572 ] The rte_errno shouldn't have assigned negative error codes, so it has to be fixed. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 6d06fcba8..6f424337e 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2009,5 +2009,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, (ol_flags & PKT_TX_L4_MASK) == PKT_TX_SCTP_CKSUM) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } @@ -2016,5 +2016,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, ret = rte_validate_tx_offload(m); if (ret != 0) { - rte_errno = ret; + rte_errno = -ret; return i; } @@ -2029,5 +2029,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, ol_flags & ~PKT_TX_TCP_SEG); if (ret != 0) { - rte_errno = ret; + rte_errno = -ret; return i; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:57.089813432 +0000 +++ 0063-net-ena-fix-errno-to-positive-value.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,13 +1,14 @@ -From baeed5f404dd1b049118cfec26a2fd3203671572 Mon Sep 17 00:00:00 2001 +From b1c6319021c04f2032ceb0de0eb3b7cab3063365 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Fri, 25 Jan 2019 09:10:26 +0100 Subject: [PATCH] net/ena: fix errno to positive value +[ upstream commit baeed5f404dd1b049118cfec26a2fd3203671572 ] + The rte_errno shouldn't have assigned negative error codes, so it has to be fixed. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") -Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk --- @@ -15,24 +16,24 @@ 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c -index 747390bb7..8bb05caa2 100644 +index 6d06fcba8..6f424337e 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c -@@ -2179,5 +2179,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -2009,5 +2009,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, (ol_flags & PKT_TX_L4_MASK) == PKT_TX_SCTP_CKSUM) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } -@@ -2186,5 +2186,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -2016,5 +2016,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, ret = rte_validate_tx_offload(m); if (ret != 0) { - rte_errno = ret; + rte_errno = -ret; return i; } -@@ -2199,5 +2199,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -2029,5 +2029,5 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, ol_flags & ~PKT_TX_TCP_SEG); if (ret != 0) { - rte_errno = ret;