From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C3A1F1B535 for ; Thu, 7 Feb 2019 14:28:48 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28F238E69A; Thu, 7 Feb 2019 13:28:48 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1977F600C4; Thu, 7 Feb 2019 13:28:46 +0000 (UTC) From: Kevin Traynor To: Luca Boccassi Cc: Gavin Hu , Bruce Richardson , dpdk stable Date: Thu, 7 Feb 2019 13:26:11 +0000 Message-Id: <20190207132614.20538-65-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 07 Feb 2019 13:28:48 +0000 (UTC) Subject: [dpdk-stable] patch 'build: mention -march in pkg-config description' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:49 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 14ae4f0e3b7fe8147a11d5c0f54b4cab04159e9e Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Thu, 10 Jan 2019 17:28:06 +0000 Subject: [PATCH] build: mention -march in pkg-config description [ upstream commit ccee5d18a470242ee86c58c9203b40ca112a49b3 ] Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers. This might cause problems, especially in distributions, so add a note in the pkg-config description. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") Signed-off-by: Luca Boccassi Reviewed-by: Gavin Hu Acked-by: Bruce Richardson --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 636626ae5..9b3a74a2a 100644 --- a/meson.build +++ b/meson.build @@ -84,5 +84,7 @@ pkg.generate(name: meson.project_name(), libraries_private: dpdk_drivers + dpdk_static_libraries + ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, - description: 'The Data Plane Development Kit (DPDK)', + description: '''The Data Plane Development Kit (DPDK). +Note that CFLAGS might contain an -march flag higher than typical baseline. +This is required for a number of static inline functions in the public headers.''', subdirs: [get_option('include_subdir_arch'), '.'], extra_cflags: ['-include', 'rte_config.h'] + machine_args -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:57.138396021 +0000 +++ 0065-build-mention-march-in-pkg-config-description.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From ccee5d18a470242ee86c58c9203b40ca112a49b3 Mon Sep 17 00:00:00 2001 +From 14ae4f0e3b7fe8147a11d5c0f54b4cab04159e9e Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Thu, 10 Jan 2019 17:28:06 +0000 Subject: [PATCH] build: mention -march in pkg-config description +[ upstream commit ccee5d18a470242ee86c58c9203b40ca112a49b3 ] + Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers. @@ -10,7 +12,6 @@ in the pkg-config description. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") -Cc: stable@dpdk.org Signed-off-by: Luca Boccassi Reviewed-by: Gavin Hu @@ -20,7 +21,7 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build -index fcc30aba7..68429f850 100644 +index 636626ae5..9b3a74a2a 100644 --- a/meson.build +++ b/meson.build @@ -84,5 +84,7 @@ pkg.generate(name: meson.project_name(),