From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6ABD11B51E for ; Thu, 7 Feb 2019 14:28:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D056C50F45; Thu, 7 Feb 2019 13:28:51 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6F77600C4; Thu, 7 Feb 2019 13:28:50 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: Kevin Traynor , dpdk stable Date: Thu, 7 Feb 2019 13:26:14 +0000 Message-Id: <20190207132614.20538-68-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Feb 2019 13:28:51 +0000 (UTC) Subject: [dpdk-stable] patch 'doc: clarify libnuma requirement for NUMA systems' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:28:52 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 39ce967019925bc923a7d0a41b09bfa4f0c106c6 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 31 Jan 2019 17:05:51 +0000 Subject: [PATCH] doc: clarify libnuma requirement for NUMA systems [ upstream commit e39d9b63664ae44af6214fa236cd989850a50833 ] Since 18.05, libnuma is pretty much required on Linux when using non-legacy mode, because without it, we cannot know where our hugepages are located [1]. In legacy mode, libnuma is not required because we can still sort pages by sockets, as we use pagemap lookup method to figure out socket ID's for pages. So, document libnuma as required for NUMA systems and non-legacy mode. [1] https://mails.dpdk.org/archives/dev/2018-December/120490.html Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") Signed-off-by: Anatoly Burakov Acked-by: Kevin Traynor --- doc/guides/linux_gsg/sys_reqs.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index 29c5f47a5..1c6f86a20 100644 --- a/doc/guides/linux_gsg/sys_reqs.rst +++ b/doc/guides/linux_gsg/sys_reqs.rst @@ -71,4 +71,13 @@ Compilation of the DPDK * libnuma-dev in Debian/Ubuntu; + .. note:: + + On systems with NUMA support, `libnuma-dev` (aka `numactl-devel`) + is a recommended dependency when `--legacy-mem` switch is used, + and a *required* dependency if default memory mode is used. + While DPDK will compile and run without `libnuma` + even on NUMA-enabled systems, + both usability and performance will be degraded. + * Python, version 2.7+ or 3.2+, to use various helper scripts included in the DPDK package. -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:57.211345859 +0000 +++ 0068-doc-clarify-libnuma-requirement-for-NUMA-systems.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,8 +1,10 @@ -From e39d9b63664ae44af6214fa236cd989850a50833 Mon Sep 17 00:00:00 2001 +From 39ce967019925bc923a7d0a41b09bfa4f0c106c6 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 31 Jan 2019 17:05:51 +0000 Subject: [PATCH] doc: clarify libnuma requirement for NUMA systems +[ upstream commit e39d9b63664ae44af6214fa236cd989850a50833 ] + Since 18.05, libnuma is pretty much required on Linux when using non-legacy mode, because without it, we cannot know where our hugepages are located [1]. @@ -17,7 +19,6 @@ [1] https://mails.dpdk.org/archives/dev/2018-December/120490.html Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") -Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Kevin Traynor @@ -26,7 +27,7 @@ 1 file changed, 9 insertions(+) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst -index 8ec3af491..d0cb66f6b 100644 +index 29c5f47a5..1c6f86a20 100644 --- a/doc/guides/linux_gsg/sys_reqs.rst +++ b/doc/guides/linux_gsg/sys_reqs.rst @@ -71,4 +71,13 @@ Compilation of the DPDK