From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C26761B3B5 for ; Thu, 7 Feb 2019 14:27:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A26E13CE4; Thu, 7 Feb 2019 13:27:16 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00CC5690EA; Thu, 7 Feb 2019 13:27:14 +0000 (UTC) From: Kevin Traynor To: Gaetan Rivet Cc: dpdk stable Date: Thu, 7 Feb 2019 13:25:15 +0000 Message-Id: <20190207132614.20538-9-ktraynor@redhat.com> In-Reply-To: <20190207132614.20538-1-ktraynor@redhat.com> References: <20190207132614.20538-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Feb 2019 13:27:16 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: fix log level of error in option register' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:27:17 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 02985c04b6538002c1702626c3f9fd08ddc0a0c3 Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Thu, 20 Dec 2018 18:06:45 +0100 Subject: [PATCH] eal: fix log level of error in option register [ upstream commit d3bdefef22b8f653eb9a26093e9a498f2da792d8 ] INFO is not correct when logging an error. Fixes: 2395332798d0 ("eal: add option register infrastructure") Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/rte_option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c index 088e0fd23..198de6d2e 100644 --- a/lib/librte_eal/common/rte_option.c +++ b/lib/librte_eal/common/rte_option.c @@ -37,5 +37,5 @@ rte_option_register(struct rte_option *opt) TAILQ_FOREACH(option, &rte_option_list, next) { if (strcmp(opt->opt_str, option->opt_str) == 0) { - RTE_LOG(INFO, EAL, "Option %s has already been registered.\n", + RTE_LOG(ERR, EAL, "Option %s has already been registered.\n", opt->opt_str); return; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-02-07 13:19:55.733210879 +0000 +++ 0009-eal-fix-log-level-of-error-in-option-register.patch 2019-02-07 13:19:55.000000000 +0000 @@ -1,12 +1,13 @@ -From d3bdefef22b8f653eb9a26093e9a498f2da792d8 Mon Sep 17 00:00:00 2001 +From 02985c04b6538002c1702626c3f9fd08ddc0a0c3 Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Thu, 20 Dec 2018 18:06:45 +0100 Subject: [PATCH] eal: fix log level of error in option register +[ upstream commit d3bdefef22b8f653eb9a26093e9a498f2da792d8 ] + INFO is not correct when logging an error. Fixes: 2395332798d0 ("eal: add option register infrastructure") -Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet --- @@ -14,15 +15,15 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c -index ae8a0e2ca..b2c93b220 100644 +index 088e0fd23..198de6d2e 100644 --- a/lib/librte_eal/common/rte_option.c +++ b/lib/librte_eal/common/rte_option.c -@@ -57,5 +57,5 @@ rte_option_register(struct rte_option *opt) +@@ -37,5 +37,5 @@ rte_option_register(struct rte_option *opt) TAILQ_FOREACH(option, &rte_option_list, next) { - if (strcmp(opt->name, option->name) == 0) { + if (strcmp(opt->opt_str, option->opt_str) == 0) { - RTE_LOG(INFO, EAL, "Option %s has already been registered.\n", + RTE_LOG(ERR, EAL, "Option %s has already been registered.\n", - opt->name); + opt->opt_str); return; -- 2.19.0