From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"rmody@marvell.com" <rmody@marvell.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"shshaikh@marvell.com" <shshaikh@marvell.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat
Date: Thu, 7 Feb 2019 13:27:36 +0000 [thread overview]
Message-ID: <20190207132736.GA61876@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <b3966cf6-d8e6-b123-82c7-67787b7a119f@intel.com>
On Thu, Feb 07, 2019 at 11:56:30AM +0000, Ferruh Yigit wrote:
> On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chaitanya Babu Talluri
> >> Sent: Friday, January 18, 2019 8:54 PM
> >> To: dev@dpdk.org
> >> Cc: rmody@marvell.com; Pattan, Reshma <reshma.pattan@intel.com>;
> >> shshaikh@marvell.com; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> >> <qi.z.zhang@intel.com>; alejandro.lucero@netronome.com; De Lara Guarch,
> >> Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> >> <declan.doherty@intel.com>; Chaitanya Babu, TalluriX
> >> <tallurix.chaitanya.babu@intel.com>; stable@dpdk.org
> >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat
> >>
> >> Strcat does not check the destination length and there might be chances of
> >> string overflow so insted of strcat, strncat is used.
> >>
> >> Fixes: 540a211084 ("bnx2x: driver core")
> >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info")
> >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess")
> >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
>
> <...>
>
> >
> > Any Review Please!!
> >
>
> cc'ed Bruce & Thomas.
>
> What do you think getting strlcat() patch first and updating this patch to use
> strlcat()?
>
> Are we OK to get strlcat as the default API?
>
"strlcat" is just saner to use, so +1 for this approach.
/Bruce
next prev parent reply other threads:[~2019-02-07 13:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:04 [dpdk-stable] [PATCH] " Chaitanya Babu Talluri
2019-01-14 13:29 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-01-14 16:24 ` Stephen Hemminger
2019-01-17 16:44 ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15 1:53 ` Thomas Monjalon
2019-01-18 15:11 ` [dpdk-stable] [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43 ` [dpdk-stable] [dpdk-dev] " Parthasarathy, JananeeX M
2019-02-07 11:56 ` Ferruh Yigit
2019-02-07 12:08 ` Thomas Monjalon
2019-02-07 13:27 ` Bruce Richardson [this message]
2019-02-13 11:54 ` Ferruh Yigit
2019-02-27 6:02 ` [dpdk-stable] [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27 9:43 ` Ferruh Yigit
2019-02-27 9:49 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-02-27 10:26 ` [dpdk-stable] " Pattan, Reshma
2019-03-05 13:14 ` [dpdk-stable] [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14 ` Ferruh Yigit
2019-03-07 12:56 ` [dpdk-stable] [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-03-14 13:34 ` [dpdk-stable] [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 14:09 ` Pattan, Reshma
2019-03-18 12:41 ` [dpdk-stable] [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-20 20:18 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-03-22 7:51 ` [dpdk-stable] [PATCH v8] " Chaitanya Babu Talluri
2019-03-22 8:02 ` [dpdk-stable] [EXT] " Shahed Shaikh
2019-03-22 10:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207132736.GA61876@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).