From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: stable@dpdk.org, yskoh@mellanox.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Ilya Maximets <i.maximets@samsung.com>
Subject: [dpdk-stable] [PATCH v17.11 LTS] vhost: fix payload size of reply
Date: Tue, 26 Feb 2019 11:21:01 +0100 [thread overview]
Message-ID: <20190226102101.1454-1-maxime.coquelin@redhat.com> (raw)
[ upstream commit 57b4d90b5893db2678ca3e28c50e1fcd37bb9b91 ]
QEMU doesn't expect any payload for the reply of
VHOST_USER_SET_LOG_BASE request, so don't send any.
Note that the Vhost-user specification isn't clear about
it and would need to be fixed.
Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request")
Cc: stable@dpdk.org
Reported-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/vhost_user.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index d70778b22..74c286e34 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1437,8 +1437,11 @@ vhost_user_msg_handler(int vid, int fd)
case VHOST_USER_SET_LOG_BASE:
vhost_user_set_log_base(dev, &msg);
- /* it needs a reply */
- msg.size = sizeof(msg.payload.u64);
+ /*
+ * The spec is not clear about it (yet), but QEMU doesn't
+ * expect any payload in the reply.
+ */
+ msg.size = 0;
send_vhost_reply(fd, &msg);
break;
case VHOST_USER_SET_LOG_FD:
--
2.20.1
next reply other threads:[~2019-02-26 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 10:21 Maxime Coquelin [this message]
2019-03-04 19:19 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226102101.1454-1-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=i.maximets@samsung.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).