From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id 153442C30
for <stable@dpdk.org>; Tue, 26 Feb 2019 11:21:09 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 7470C5D5FC;
Tue, 26 Feb 2019 10:21:08 +0000 (UTC)
Received: from localhost.localdomain (ovpn-112-64.ams2.redhat.com
[10.36.112.64])
by smtp.corp.redhat.com (Postfix) with ESMTP id 7729316D2B;
Tue, 26 Feb 2019 10:21:04 +0000 (UTC)
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: stable@dpdk.org,
yskoh@mellanox.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Ilya Maximets <i.maximets@samsung.com>
Date: Tue, 26 Feb 2019 11:21:01 +0100
Message-Id: <20190226102101.1454-1-maxime.coquelin@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.39]); Tue, 26 Feb 2019 10:21:08 +0000 (UTC)
Subject: [dpdk-stable] [PATCH v17.11 LTS] vhost: fix payload size of reply
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2019 10:21:09 -0000
[ upstream commit 57b4d90b5893db2678ca3e28c50e1fcd37bb9b91 ]
QEMU doesn't expect any payload for the reply of
VHOST_USER_SET_LOG_BASE request, so don't send any.
Note that the Vhost-user specification isn't clear about
it and would need to be fixed.
Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request")
Cc: stable@dpdk.org
Reported-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/vhost_user.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index d70778b22..74c286e34 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1437,8 +1437,11 @@ vhost_user_msg_handler(int vid, int fd)
case VHOST_USER_SET_LOG_BASE:
vhost_user_set_log_base(dev, &msg);
- /* it needs a reply */
- msg.size = sizeof(msg.payload.u64);
+ /*
+ * The spec is not clear about it (yet), but QEMU doesn't
+ * expect any payload in the reply.
+ */
+ msg.size = 0;
send_vhost_reply(fd, &msg);
break;
case VHOST_USER_SET_LOG_FD:
--
2.20.1