From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 06BF12B91 for ; Fri, 8 Mar 2019 18:48:37 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Mar 2019 19:48:37 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x28HloAh002625; Fri, 8 Mar 2019 19:48:35 +0200 From: Yongseok Koh To: Fiona Trahe Cc: Pablo de Lara , dpdk stable Date: Fri, 8 Mar 2019 09:47:05 -0800 Message-Id: <20190308174749.30771-27-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190308174749.30771-1-yskoh@mellanox.com> References: <20190308174749.30771-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'test/crypto: fix misleading trace message' has been queued to LTS release 17.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 17:48:38 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 03/13/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 1576909015809048ae08b8723d4ca9d507430d52 Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Fri, 21 Dec 2018 00:01:25 +0000 Subject: [PATCH] test/crypto: fix misleading trace message [ upstream commit 1113ba1dcb7e78a8a839c294523e1939d14aae98 ] Test was reporting digest verification failed for all operation errors. Fixed so it only reports this if the PMD actually reports an auth failure. Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test") Signed-off-by: Fiona Trahe Acked-by: Pablo de Lara --- test/test/test_cryptodev_blockcipher.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c index 20f3296d2..945636b68 100644 --- a/test/test/test_cryptodev_blockcipher.c +++ b/test/test/test_cryptodev_blockcipher.c @@ -403,13 +403,14 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, /* Verify results */ if (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) { - if (t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY) + if ((t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY) && + (op->status == RTE_CRYPTO_OP_STATUS_AUTH_FAILED)) snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u " "FAILED: Digest verification failed " "(0x%X)", __LINE__, op->status); else snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u " - "FAILED: Digest verification failed " + "FAILED: Operation failed " "(0x%X)", __LINE__, op->status); status = TEST_FAILED; goto error_exit; -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-03-08 09:46:41.669081427 -0800 +++ 0027-test-crypto-fix-misleading-trace-message.patch 2019-03-08 09:46:40.106403000 -0800 @@ -1,13 +1,14 @@ -From 1113ba1dcb7e78a8a839c294523e1939d14aae98 Mon Sep 17 00:00:00 2001 +From 1576909015809048ae08b8723d4ca9d507430d52 Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Fri, 21 Dec 2018 00:01:25 +0000 Subject: [PATCH] test/crypto: fix misleading trace message +[ upstream commit 1113ba1dcb7e78a8a839c294523e1939d14aae98 ] + Test was reporting digest verification failed for all operation errors. Fixed so it only reports this if the PMD actually reports an auth failure. Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test") -Cc: stable@dpdk.org Signed-off-by: Fiona Trahe Acked-by: Pablo de Lara @@ -16,10 +17,10 @@ 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c -index 1c3f29f6b..4f1298ea2 100644 +index 20f3296d2..945636b68 100644 --- a/test/test/test_cryptodev_blockcipher.c +++ b/test/test/test_cryptodev_blockcipher.c -@@ -401,13 +401,14 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, +@@ -403,13 +403,14 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, /* Verify results */ if (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {