From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 292A72BA5 for ; Fri, 8 Mar 2019 18:48:53 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Mar 2019 19:48:51 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x28HloAp002625; Fri, 8 Mar 2019 19:48:49 +0200 From: Yongseok Koh To: Julien Meunier Cc: Xiao Wang , dpdk stable Date: Fri, 8 Mar 2019 09:47:13 -0800 Message-Id: <20190308174749.30771-35-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190308174749.30771-1-yskoh@mellanox.com> References: <20190308174749.30771-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/fm10k: fix internal switch initial status' has been queued to LTS release 17.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 17:48:53 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 03/13/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From b0682f05b1142808c8b8f53765316ca67bca5743 Mon Sep 17 00:00:00 2001 From: Julien Meunier Date: Wed, 2 Jan 2019 17:57:45 +0200 Subject: [PATCH] net/fm10k: fix internal switch initial status [ upstream commit 04018a4552e630a2c019bade0c6b5f822aded0c1 ] sm_down is a boolean in order to check if the internal switch of the fm10k is up or down. This variable is configured though an interrupt by fm10k_dev_interrupt_handler_pf. If sm_down is uninitialized, we are not sure of its value at the first bring up. For example, if FM10K_EICR_SWITCHREADY is raised, the PMD will try to reconfigure the switch, but it does not make sense, as it's the first startup. The sm_down implementation has been introduced commit 6c9f37245583 ("net/fm10k: support switch restart on PF"). Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") Signed-off-by: Julien Meunier Acked-by: Xiao Wang --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index a0263f6d7..9ca57e582 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -2987,6 +2987,7 @@ fm10k_params_init(struct rte_eth_dev *dev) hw->bus.payload = fm10k_bus_payload_256; info->rx_vec_allowed = true; + info->sm_down = false; } static int -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-03-08 09:46:42.028024465 -0800 +++ 0035-net-fm10k-fix-internal-switch-initial-status.patch 2019-03-08 09:46:40.159400000 -0800 @@ -1,8 +1,10 @@ -From 04018a4552e630a2c019bade0c6b5f822aded0c1 Mon Sep 17 00:00:00 2001 +From b0682f05b1142808c8b8f53765316ca67bca5743 Mon Sep 17 00:00:00 2001 From: Julien Meunier Date: Wed, 2 Jan 2019 17:57:45 +0200 Subject: [PATCH] net/fm10k: fix internal switch initial status +[ upstream commit 04018a4552e630a2c019bade0c6b5f822aded0c1 ] + sm_down is a boolean in order to check if the internal switch of the fm10k is up or down. This variable is configured though an interrupt by fm10k_dev_interrupt_handler_pf. @@ -16,7 +18,6 @@ commit 6c9f37245583 ("net/fm10k: support switch restart on PF"). Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") -Cc: stable@dpdk.org Signed-off-by: Julien Meunier Acked-by: Xiao Wang @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c -index 85fb6c5cb..caf4d1bc0 100644 +index a0263f6d7..9ca57e582 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c -@@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev) +@@ -2987,6 +2987,7 @@ fm10k_params_init(struct rte_eth_dev *dev) hw->bus.payload = fm10k_bus_payload_256; info->rx_vec_allowed = true;