From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 9E230A3 for ; Fri, 8 Mar 2019 18:49:22 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Mar 2019 19:49:17 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x28HloB8002625; Fri, 8 Mar 2019 19:49:16 +0200 From: Yongseok Koh To: Andrew Rybchenko Cc: dpdk stable Date: Fri, 8 Mar 2019 09:47:30 -0800 Message-Id: <20190308174749.30771-52-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190308174749.30771-1-yskoh@mellanox.com> References: <20190308174749.30771-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/sfc: fix VF error/missed stats mapping' has been queued to LTS release 17.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 17:49:23 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 03/13/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 9be0a39e3d7a488289f1d5796243c279677e948b Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Wed, 16 Jan 2019 09:43:23 +0000 Subject: [PATCH] net/sfc: fix VF error/missed stats mapping [ upstream commit 24f8a95917b36b313a49bd604c3958f992893efd ] VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed packet because of overflow. VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions, but mainly impossibility to deliver because of no descriptors available, so it is better to classify it as imissed. Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 005df401d..089e8535e 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -552,8 +552,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) mac_stats[EFX_MAC_VADAPTER_TX_UNICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]; - stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_OVERFLOW]; - stats->ierrors = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; + stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; stats->oerrors = mac_stats[EFX_MAC_VADAPTER_TX_BAD_PACKETS]; } else { stats->ipackets = mac_stats[EFX_MAC_RX_PKTS]; -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-03-08 09:46:42.790714255 -0800 +++ 0052-net-sfc-fix-VF-error-missed-stats-mapping.patch 2019-03-08 09:46:40.267403000 -0800 @@ -1,8 +1,10 @@ -From 24f8a95917b36b313a49bd604c3958f992893efd Mon Sep 17 00:00:00 2001 +From 9be0a39e3d7a488289f1d5796243c279677e948b Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Wed, 16 Jan 2019 09:43:23 +0000 Subject: [PATCH] net/sfc: fix VF error/missed stats mapping +[ upstream commit 24f8a95917b36b313a49bd604c3958f992893efd ] + VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed packet because of overflow. @@ -11,7 +13,6 @@ available, so it is better to classify it as imissed. Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") -Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko --- @@ -19,10 +20,10 @@ 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c -index 3886daf7a..9f59c8db9 100644 +index 005df401d..089e8535e 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c -@@ -537,8 +537,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) +@@ -552,8 +552,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) mac_stats[EFX_MAC_VADAPTER_TX_UNICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES];