From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id BBDEB2BA5 for ; Fri, 8 Mar 2019 18:49:32 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Mar 2019 19:49:31 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x28HloBG002625; Fri, 8 Mar 2019 19:49:30 +0200 From: Yongseok Koh To: Shahed Shaikh Cc: Rasesh Mody , dpdk stable Date: Fri, 8 Mar 2019 09:47:38 -0800 Message-Id: <20190308174749.30771-60-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190308174749.30771-1-yskoh@mellanox.com> References: <20190308174749.30771-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/qede: remove prefetch in Tx path' has been queued to LTS release 17.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 17:49:33 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 03/13/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From a80ab4ac151985069f1a00e7cc53d3c2eea76113 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Fri, 18 Jan 2019 02:29:30 -0800 Subject: [PATCH] net/qede: remove prefetch in Tx path [ upstream commit d6ddd17fb17cb250044bada4ae42a799375fd6c5 ] Incorrect placement of prefetch in Tx path is causing a performance drop of around ~2% on AMD platform. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Shahed Shaikh Acked-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index b525075ca..7ef76edc3 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -2182,7 +2182,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->nb_tx_avail -= bd1->data.nbds; txq->sw_tx_prod++; - rte_prefetch0(txq->sw_tx_ring[TX_PROD(txq)].mbuf); bd_prod = rte_cpu_to_le_16(ecore_chain_get_prod_idx(&txq->tx_pbl)); #ifdef RTE_LIBRTE_QEDE_DEBUG_TX -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-03-08 09:46:43.150710636 -0800 +++ 0060-net-qede-remove-prefetch-in-Tx-path.patch 2019-03-08 09:46:40.317403000 -0800 @@ -1,13 +1,14 @@ -From d6ddd17fb17cb250044bada4ae42a799375fd6c5 Mon Sep 17 00:00:00 2001 +From a80ab4ac151985069f1a00e7cc53d3c2eea76113 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Fri, 18 Jan 2019 02:29:30 -0800 Subject: [PATCH] net/qede: remove prefetch in Tx path +[ upstream commit d6ddd17fb17cb250044bada4ae42a799375fd6c5 ] + Incorrect placement of prefetch in Tx path is causing a performance drop of around ~2% on AMD platform. Fixes: 2ea6f76aff40 ("qede: add core driver") -Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh Acked-by: Rasesh Mody @@ -16,10 +17,10 @@ 1 file changed, 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c -index 684c4aeef..eda19b2b1 100644 +index b525075ca..7ef76edc3 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c -@@ -2181,7 +2181,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) +@@ -2182,7 +2182,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->nb_tx_avail -= bd1->data.nbds; txq->sw_tx_prod++;