From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 147DB2C24; Mon, 11 Mar 2019 17:31:46 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2019 09:31:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,468,1544515200"; d="scan'208";a="133138243" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by orsmga003.jf.intel.com with SMTP; 11 Mar 2019 09:31:43 -0700 Received: by (sSMTP sendmail emulation); Mon, 11 Mar 2019 16:31:42 +0000 Date: Mon, 11 Mar 2019 16:31:42 +0000 From: Bruce Richardson To: Andrius Sirvys Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com> References: <1552317491-161841-1-git-send-email-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1552317491-161841-1-git-send-email-andrius.sirvys@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-stable] [PATCH v2] acl: fix missing flags when compiling without AVX2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 16:31:47 -0000 On Mon, Mar 11, 2019 at 03:18:11PM +0000, Andrius Sirvys wrote: > When compiling the ACL library on a system without AVX2 support, > the flags used to compile the AVX2-specific code for later run-time > use were not based on the regular cflags for the rest of the library. > This can cause errors due to symbols being missed/undefined > due to incorrect flags. For example, > when testing compilation on Alpine linux, we got: > error: unknown type name 'cpu_set_t' > due to _GNU_SOURCE not being defined in the cflags. > > This issue can be fixed by appending "-mavx2" to > the cflags rather than replacing them with it. > > Fixes: 5b9656b157d3 ("lib: build with meson") > Cc: stable@dpdk.org > > Signed-off-by: Andrius Sirvys > --- > Cc: bruce.richardson@intel.com > > v2: fixed spelling errors in code > --- > lib/librte_acl/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_acl/meson.build b/lib/librte_acl/meson.build > index aec792f..58d346a 100644 > --- a/lib/librte_acl/meson.build > +++ b/lib/librte_acl/meson.build > @@ -23,7 +23,7 @@ if arch_subdir == 'x86' > avx2_tmplib = static_library('avx2_tmp', > 'acl_run_avx2.c', > dependencies: static_rte_eal, > - c_args: '-mavx2') > + c_args: cflags + ['-mavx2']) > objs += avx2_tmplib.extract_objects('acl_run_avx2.c') > cflags += '-DCC_AVX2_SUPPORT' > endif Looks to be 2 spaces rather than 1 before the opening "[", but not a big deal and can be fixed on apply if necessary. Acked-by: Bruce Richardson