patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] doc: add guideines for initial PMD submission
@ 2019-04-09 17:36 Rami Rosen
  2019-04-10 10:06 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
  0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-04-09 17:36 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, pablo.de.lara.guarch, akhil.goyal, john.mcnamara,
	marko.kovacevic, Rami Rosen, stable

This patch for DPDK Contributor's Guidelines indicates the repos
against which a new PMD should be prepared; for new network ethernet
PMDs it should be dpdk-next-net, and for new crypto PMDs
it should be dpdk-next-crypto. Though this may seem obvious, it
is not mentioned in DPDK documentation.

Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 doc/guides/contributing/patches.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index d8404e623..4dde8e724 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -148,6 +148,10 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines
 
 * If you add new files or directories you should add your name to the ``MAINTAINERS`` file.
 
+* If you add a new network PMD you should prepare the initial submission against dpdk-next-net repo.
+
+* If you add a new crypto PMD you should prepare the initial submission against dpdk-next-crypto repo.
+
 * New external functions should be added to the local ``version.map`` file.
   See the :doc:`Guidelines for ABI policy and versioning </contributing/versioning>`.
   New external functions should also be added in alphabetical order.
-- 
2.19.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: add guideines for initial PMD submission
  2019-04-09 17:36 [dpdk-stable] [PATCH] doc: add guideines for initial PMD submission Rami Rosen
@ 2019-04-10 10:06 ` Trahe, Fiona
  2019-04-10 14:36   ` Rami Rosen
  0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2019-04-10 10:06 UTC (permalink / raw)
  To: Rami Rosen, dev
  Cc: Yigit, Ferruh, De Lara Guarch, Pablo, akhil.goyal, Mcnamara,
	John, Kovacevic, Marko, stable, Trahe, Fiona

Hi Rami,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Tuesday, April 9, 2019 6:37 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> akhil.goyal@nxp.com; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Rami Rosen <ramirose@gmail.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add guideines for initial PMD submission
> 
> This patch for DPDK Contributor's Guidelines indicates the repos
> against which a new PMD should be prepared; for new network ethernet
> PMDs it should be dpdk-next-net, and for new crypto PMDs
> it should be dpdk-next-crypto. Though this may seem obvious, it
> is not mentioned in DPDK documentation.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  doc/guides/contributing/patches.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index d8404e623..4dde8e724 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -148,6 +148,10 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some
> guidelines
> 
>  * If you add new files or directories you should add your name to the ``MAINTAINERS`` file.
> 
> +* If you add a new network PMD you should prepare the initial submission against dpdk-next-net repo.
> +
> +* If you add a new crypto PMD you should prepare the initial submission against dpdk-next-crypto repo.
[Fiona] Good idea to add this patch. However despite the name crypto is actual broader.... so maybe
"If you add a new crypto or compression PMD.... "


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: add guideines for initial PMD submission
  2019-04-10 10:06 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
@ 2019-04-10 14:36   ` Rami Rosen
  0 siblings, 0 replies; 3+ messages in thread
From: Rami Rosen @ 2019-04-10 14:36 UTC (permalink / raw)
  To: Trahe, Fiona
  Cc: dev, Yigit, Ferruh, De Lara Guarch, Pablo, akhil.goyal, Mcnamara,
	John, Kovacevic, Marko, stable

Hi Fiona,
>[Fiona] Good idea to add this patch. However despite the name crypto is
actual broader.... so maybe
>"If you add a new crypto or compression PMD.... "

Thanks for this feedback, I will fix it in V2 of the patch.

Regards,
Rami Rosen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-10 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 17:36 [dpdk-stable] [PATCH] doc: add guideines for initial PMD submission Rami Rosen
2019-04-10 10:06 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2019-04-10 14:36   ` Rami Rosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).