From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DB7DFA0096 for ; Wed, 10 Apr 2019 16:01:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A91511B141; Wed, 10 Apr 2019 16:01:13 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 22F111B119; Wed, 10 Apr 2019 16:01:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 07:01:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="141574414" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by orsmga003.jf.intel.com with ESMTP; 10 Apr 2019 07:01:04 -0700 From: Ferruh Yigit To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 10 Apr 2019 15:00:58 +0100 Message-Id: <20190410140058.26782-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190410140058.26782-1-ferruh.yigit@intel.com> References: <20190410140058.26782-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH 2/2] build: fix crash by disabling AVX512 with binutils 2.31 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Skylake platform, with native build, KNI kernel module crashes because of the corrupted values passed to kernel module. The corruption occurs because the userspace kni library works unexpectedly. Compiler [1] is using AVX512 instructions and generated binary is wrong [2]. It turned around gcc does its job correct, but gas is generating binary wrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has been fixed in binutils 2.32 with: Commit x86: don't mistakenly scale non-8-bit displacements AVX512 was already disabled with bintuils 2.30 [3], extending it to 2.31 & 2.31.1 too. [1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2) [2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 [3] Bugzilla ID 97 has the details. Bugzilla ID: 249 Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- config/x86/meson.build | 6 ++++++ mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 692aebe7a..9e9d5dc8c 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -10,6 +10,12 @@ if host_machine.system() != 'windows' message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') endif endif + if ldver.contains('2.31') + if cc.has_argument('-mno-avx512f') + machine_args += '-mno-avx512f' + message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249') + endif + endif endif # we require SSE4.2 for DPDK diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index df71e4a8b..ea40a11c0 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),) FORCE_DISABLE_AVX512 := y # print warning only once for librte_eal ifneq ($(filter %librte_eal,$(CURDIR)),) -$(warning AVX512 support disabled because of ld 2.30. See Bug 97) +$(warning AVX512 support disabled because of binutils 2.30. See Bug 97) +endif +endif +ifneq ($(filter 2.31%,$(LD_VERSION)),) +FORCE_DISABLE_AVX512 := y +# print warning only once for librte_eal +ifneq ($(filter %librte_eal,$(CURDIR)),) +$(warning AVX512 support disabled because of binutils 2.31. See Bug 249) endif endif endif -- 2.20.1