From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98F37A0096 for ; Wed, 10 Apr 2019 18:44:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 875091B105; Wed, 10 Apr 2019 18:44:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E52DF1B130 for ; Wed, 10 Apr 2019 18:44:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54A11C78F7; Wed, 10 Apr 2019 16:44:50 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30A4F5D961; Wed, 10 Apr 2019 16:44:49 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: Maxime Coquelin , Tiwei Bie , dpdk stable Date: Wed, 10 Apr 2019 17:43:29 +0100 Message-Id: <20190410164411.10546-21-ktraynor@redhat.com> In-Reply-To: <20190410164411.10546-1-ktraynor@redhat.com> References: <20190410164411.10546-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 10 Apr 2019 16:44:50 +0000 (UTC) Subject: [dpdk-stable] patch 'vhost: fix sprintf with snprintf' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 0eadea12338d0b5db98b87e59507d2a8132673c7 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:28:06 +0000 Subject: [PATCH] vhost: fix sprintf with snprintf [ upstream commit 7c7b7562252742a6c298de64df486873336fd058 ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: d7280c9fffcb ("vhost: support selective datapath") Signed-off-by: Pallantla Poornima Reviewed-by: Maxime Coquelin Acked-by: Tiwei Bie --- lib/librte_vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c index e7d849ee0..ae721e06b 100644 --- a/lib/librte_vhost/vdpa.c +++ b/lib/librte_vhost/vdpa.c @@ -67,5 +67,5 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr, return -1; - sprintf(device_name, "vdpa-dev-%d", i); + snprintf(device_name, sizeof(device_name), "vdpa-dev-%d", i); dev = rte_zmalloc(device_name, sizeof(struct rte_vdpa_device), RTE_CACHE_LINE_SIZE); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-10 14:06:09.636535550 +0100 +++ 0021-vhost-fix-sprintf-with-snprintf.patch 2019-04-10 14:06:07.837294862 +0100 @@ -1,13 +1,14 @@ -From 7c7b7562252742a6c298de64df486873336fd058 Mon Sep 17 00:00:00 2001 +From 0eadea12338d0b5db98b87e59507d2a8132673c7 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:28:06 +0000 Subject: [PATCH] vhost: fix sprintf with snprintf +[ upstream commit 7c7b7562252742a6c298de64df486873336fd058 ] + sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: d7280c9fffcb ("vhost: support selective datapath") -Cc: stable@dpdk.org Signed-off-by: Pallantla Poornima Reviewed-by: Maxime Coquelin @@ -17,7 +18,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c -index 1ff9b00b8..321e11f17 100644 +index e7d849ee0..ae721e06b 100644 --- a/lib/librte_vhost/vdpa.c +++ b/lib/librte_vhost/vdpa.c @@ -67,5 +67,5 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,