From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 30C4CA0096 for ; Wed, 10 Apr 2019 18:45:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2724C1B11F; Wed, 10 Apr 2019 18:45:28 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 04A2C1B136 for ; Wed, 10 Apr 2019 18:45:27 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6BDF430BB342; Wed, 10 Apr 2019 16:45:26 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 645CE5D961; Wed, 10 Apr 2019 16:45:25 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: Ferruh Yigit , dpdk stable Date: Wed, 10 Apr 2019 17:43:46 +0100 Message-Id: <20190410164411.10546-38-ktraynor@redhat.com> In-Reply-To: <20190410164411.10546-1-ktraynor@redhat.com> References: <20190410164411.10546-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 10 Apr 2019 16:45:26 +0000 (UTC) Subject: [dpdk-stable] patch 'net/softnic: fix possible buffer overflow' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 111ed81e6a13a08afeb2464034ae080dfc8e2e74 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:23:48 +0000 Subject: [PATCH] net/softnic: fix possible buffer overflow [ upstream commit fef6b216390f33c066ea15e9de7845dfc3ab6d6a ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: daabf2fb949b ("net/softnic: map flow action to table action") Signed-off-by: Pallantla Poornima Reviewed-by: Ferruh Yigit --- drivers/net/softnic/rte_eth_softnic_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers/net/softnic/rte_eth_softnic_flow.c index 21e753001..aefc384dc 100644 --- a/drivers/net/softnic/rte_eth_softnic_flow.c +++ b/drivers/net/softnic/rte_eth_softnic_flow.c @@ -1284,5 +1284,6 @@ flow_rule_action_get(struct pmd_internals *softnic, "QUEUE: Invalid RX queue ID"); - sprintf(name, "RXQ%u", (uint32_t)conf->index); + snprintf(name, sizeof(name), "RXQ%u", + (uint32_t)conf->index); status = softnic_pipeline_port_out_find(softnic, @@ -1374,5 +1375,5 @@ flow_rule_action_get(struct pmd_internals *softnic, "RSS: Invalid RX queue ID"); - sprintf(name, "RXQ%u", + snprintf(name, sizeof(name), "RXQ%u", (uint32_t)conf->queue[i]); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-10 14:06:10.788597868 +0100 +++ 0038-net-softnic-fix-possible-buffer-overflow.patch 2019-04-10 14:06:07.931292710 +0100 @@ -1,13 +1,14 @@ -From fef6b216390f33c066ea15e9de7845dfc3ab6d6a Mon Sep 17 00:00:00 2001 +From 111ed81e6a13a08afeb2464034ae080dfc8e2e74 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:23:48 +0000 Subject: [PATCH] net/softnic: fix possible buffer overflow +[ upstream commit fef6b216390f33c066ea15e9de7845dfc3ab6d6a ] + sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: daabf2fb949b ("net/softnic: map flow action to table action") -Cc: stable@dpdk.org Signed-off-by: Pallantla Poornima Reviewed-by: Ferruh Yigit