From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D6955A00E6 for ; Tue, 16 Apr 2019 16:38:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDA951B4D0; Tue, 16 Apr 2019 16:38:03 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2E3871B4D3 for ; Tue, 16 Apr 2019 16:38:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9669B7E437; Tue, 16 Apr 2019 14:38:01 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2B771001E92; Tue, 16 Apr 2019 14:38:00 +0000 (UTC) From: Kevin Traynor To: Igor Russkikh Cc: dpdk stable Date: Tue, 16 Apr 2019 15:36:37 +0100 Message-Id: <20190416143719.21601-19-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 16 Apr 2019 14:38:01 +0000 (UTC) Subject: [dpdk-stable] patch 'net/atlantic: fix negative error codes' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 9a273ee2104f0b44299c0c9245d066ae54c9ea4e Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Tue, 12 Mar 2019 15:24:52 +0000 Subject: [PATCH] net/atlantic: fix negative error codes [ upstream commit 327d8206c29fe690bf2a52c75d374d8102fe29f1 ] These are just convention breakage on rte_errno, no real harm from that. Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index 40c913795..aea58c0d5 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -813,10 +813,10 @@ atl_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (m->nb_segs > AQ_HW_MAX_SEGS_SIZE) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return i; } if (ol_flags & ATL_TX_OFFLOAD_NOTSUP_MASK) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:26.074059867 +0100 +++ 0019-net-atlantic-fix-negative-error-codes.patch 2019-04-16 15:34:25.164180305 +0100 @@ -1,13 +1,14 @@ -From 327d8206c29fe690bf2a52c75d374d8102fe29f1 Mon Sep 17 00:00:00 2001 +From 9a273ee2104f0b44299c0c9245d066ae54c9ea4e Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Tue, 12 Mar 2019 15:24:52 +0000 Subject: [PATCH] net/atlantic: fix negative error codes +[ upstream commit 327d8206c29fe690bf2a52c75d374d8102fe29f1 ] + These are just convention breakage on rte_errno, no real harm from that. Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") -Cc: stable@dpdk.org Signed-off-by: Igor Russkikh ---