From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8426DA00E6 for ; Tue, 16 Apr 2019 16:38:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 614A21B4DE; Tue, 16 Apr 2019 16:38:33 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id AFEFB1B4DE for ; Tue, 16 Apr 2019 16:38:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DCBF80461; Tue, 16 Apr 2019 14:38:30 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E5371001E93; Tue, 16 Apr 2019 14:38:28 +0000 (UTC) From: Kevin Traynor To: Igor Romanov Cc: Andrew Rybchenko , Bernard Iremonger , dpdk stable Date: Tue, 16 Apr 2019 15:36:51 +0100 Message-Id: <20190416143719.21601-33-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 16 Apr 2019 14:38:30 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix stdout flush after printing stats' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From c30166747e762bfe4f7b5eff1ef02e465d095c67 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Mon, 18 Mar 2019 11:35:47 +0000 Subject: [PATCH] app/testpmd: fix stdout flush after printing stats [ upstream commit 683d1e82a0f2caae1a9c6f1209ab4d743373a173 ] User can specify stats period(n). The statistics should be available to user every n second. But the print_stats() function does not force stdout to be flushed, so for instance, a user reading testpmd's stdout through pipe will not be able to read it until the stdout buffer is filled. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7b0c8e682..2fb5e15e7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3059,4 +3059,6 @@ print_stats(void) for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) nic_stats_display(fwd_ports_ids[i]); + + fflush(stdout); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:26.661945034 +0100 +++ 0033-app-testpmd-fix-stdout-flush-after-printing-stats.patch 2019-04-16 15:34:25.182179905 +0100 @@ -1,8 +1,10 @@ -From 683d1e82a0f2caae1a9c6f1209ab4d743373a173 Mon Sep 17 00:00:00 2001 +From c30166747e762bfe4f7b5eff1ef02e465d095c67 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Mon, 18 Mar 2019 11:35:47 +0000 Subject: [PATCH] app/testpmd: fix stdout flush after printing stats +[ upstream commit 683d1e82a0f2caae1a9c6f1209ab4d743373a173 ] + User can specify stats period(n). The statistics should be available to user every n second. But the print_stats() function does not force stdout to be flushed, so for instance, a user reading testpmd's @@ -10,7 +12,6 @@ buffer is filled. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") -Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko @@ -20,10 +21,10 @@ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c -index d9d0c16d4..216be47f9 100644 +index 7b0c8e682..2fb5e15e7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c -@@ -3047,4 +3047,6 @@ print_stats(void) +@@ -3059,4 +3059,6 @@ print_stats(void) for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) nic_stats_display(fwd_ports_ids[i]); +