From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 345F9A00E6 for ; Tue, 16 Apr 2019 16:37:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14A7B1B4E3; Tue, 16 Apr 2019 16:37:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 83B041B4E2 for ; Tue, 16 Apr 2019 16:37:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8EF430833A1; Tue, 16 Apr 2019 14:37:42 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 287871001E92; Tue, 16 Apr 2019 14:37:41 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: dpdk stable Date: Tue, 16 Apr 2019 15:36:24 +0100 Message-Id: <20190416143719.21601-6-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 16 Apr 2019 14:37:43 +0000 (UTC) Subject: [dpdk-stable] patch 'event/opdl: replace sprintf with snprintf' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 5f05c4e500feb449d6744d54a8b62c19734ae386 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:18:02 +0000 Subject: [PATCH] event/opdl: replace sprintf with snprintf [ upstream commit 57362ddf4262d0440ae1bddc6eaf69e9f94f9c85 ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper function") Signed-off-by: Pallantla Poornima --- drivers/event/opdl/opdl_evdev.c | 7 ++++--- drivers/event/opdl/opdl_evdev_xstats.c | 7 +++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index a4f0bc8b6..d2d2be44b 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.c @@ -423,8 +423,9 @@ opdl_dump(struct rte_eventdev *dev, FILE *f) p_type = "????"; - sprintf(queue_id, "%02u", port->external_qid); + snprintf(queue_id, sizeof(queue_id), "%02u", + port->external_qid); if (port->p_type == OPDL_REGULAR_PORT || port->p_type == OPDL_ASYNC_PORT) - sprintf(total_cyc, + snprintf(total_cyc, sizeof(total_cyc), " %'16"PRIu64"", (cpg != 0 ? @@ -432,5 +433,5 @@ opdl_dump(struct rte_eventdev *dev, FILE *f) : 0)); else - sprintf(total_cyc, + snprintf(total_cyc, sizeof(total_cyc), " ----"); fprintf(f, diff --git a/drivers/event/opdl/opdl_evdev_xstats.c b/drivers/event/opdl/opdl_evdev_xstats.c index 0e6c6bd5e..27b3d8802 100644 --- a/drivers/event/opdl/opdl_evdev_xstats.c +++ b/drivers/event/opdl/opdl_evdev_xstats.c @@ -33,8 +33,7 @@ opdl_xstats_init(struct rte_eventdev *dev) /* Name */ - sprintf(device->port_xstat[index].stat.name, - "port_%02u_%s", - i, - port_xstat_str[j]); + snprintf(device->port_xstat[index].stat.name, + sizeof(device->port_xstat[index].stat.name), + "port_%02u_%s", i, port_xstat_str[j]); /* ID */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:25.481144220 +0100 +++ 0006-event-opdl-replace-sprintf-with-snprintf.patch 2019-04-16 15:34:25.109181525 +0100 @@ -1,13 +1,14 @@ -From 57362ddf4262d0440ae1bddc6eaf69e9f94f9c85 Mon Sep 17 00:00:00 2001 +From 5f05c4e500feb449d6744d54a8b62c19734ae386 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Mon, 4 Feb 2019 07:18:02 +0000 Subject: [PATCH] event/opdl: replace sprintf with snprintf +[ upstream commit 57362ddf4262d0440ae1bddc6eaf69e9f94f9c85 ] + sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper function") -Cc: stable@dpdk.org Signed-off-by: Pallantla Poornima ---