From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CDC9BA05D3 for ; Thu, 25 Apr 2019 17:41:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1A221B5C4; Thu, 25 Apr 2019 17:41:49 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B45131B5F7 for ; Thu, 25 Apr 2019 17:41:47 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C214308B767; Thu, 25 Apr 2019 15:41:47 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 498DB5D9D1; Thu, 25 Apr 2019 15:41:46 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: dpdk stable Date: Thu, 25 Apr 2019 16:40:15 +0100 Message-Id: <20190425154037.28778-40-ktraynor@redhat.com> In-Reply-To: <20190425154037.28778-1-ktraynor@redhat.com> References: <20190425154037.28778-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 25 Apr 2019 15:41:47 +0000 (UTC) Subject: [dpdk-stable] patch 'test/event: replace sprintf with snprintf' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/01/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches can be viewed on the 18.11 branch at: https://github.com/kevintraynor/dpdk-stable-queue.git Thanks. Kevin Traynor --- >From e4e2456fb034fe4fa81f5f8cc7881ee4fc49dc2d Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Wed, 6 Feb 2019 10:43:42 +0000 Subject: [PATCH] test/event: replace sprintf with snprintf [ upstream commit 64fc990877cdfe1973a18f47e6887e8a141a6efb ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 2a9c83ae3b ("test/eventdev: add multi-ports test") Signed-off-by: Pallantla Poornima --- test/test/test_event_eth_rx_adapter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c index 1d3be82b5..38f5c039f 100644 --- a/test/test/test_event_eth_rx_adapter.c +++ b/test/test/test_event_eth_rx_adapter.c @@ -480,5 +480,6 @@ adapter_multi_eth_add_del(void) port_index = rte_eth_dev_count_total(); for (; port_index < RTE_MAX_ETHPORTS; port_index += 1) { - sprintf(driver_name, "%s%u", "net_null", drv_id); + snprintf(driver_name, sizeof(driver_name), "%s%u", "net_null", + drv_id); err = rte_vdev_init(driver_name, NULL); TEST_ASSERT(err == 0, "Failed driver %s got %d", -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-25 16:37:48.478599240 +0100 +++ 0040-test-event-replace-sprintf-with-snprintf.patch 2019-04-25 16:37:46.750294835 +0100 @@ -1 +1 @@ -From 64fc990877cdfe1973a18f47e6887e8a141a6efb Mon Sep 17 00:00:00 2001 +From e4e2456fb034fe4fa81f5f8cc7881ee4fc49dc2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 64fc990877cdfe1973a18f47e6887e8a141a6efb ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -14 +15 @@ - app/test/test_event_eth_rx_adapter.c | 3 ++- + test/test/test_event_eth_rx_adapter.c | 3 ++- @@ -17 +18 @@ -diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c +diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c @@ -19,2 +20,2 @@ ---- a/app/test/test_event_eth_rx_adapter.c -+++ b/app/test/test_event_eth_rx_adapter.c +--- a/test/test/test_event_eth_rx_adapter.c ++++ b/test/test/test_event_eth_rx_adapter.c