From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EC116A05D3 for ; Thu, 25 Apr 2019 17:42:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E43161B5C4; Thu, 25 Apr 2019 17:42:03 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6EDF11B5F6 for ; Thu, 25 Apr 2019 17:42:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA528308FE62; Thu, 25 Apr 2019 15:42:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCC835DE66; Thu, 25 Apr 2019 15:42:00 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: David Hunt , dpdk stable Date: Thu, 25 Apr 2019 16:40:26 +0100 Message-Id: <20190425154037.28778-51-ktraynor@redhat.com> In-Reply-To: <20190425154037.28778-1-ktraynor@redhat.com> References: <20190425154037.28778-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 25 Apr 2019 15:42:01 +0000 (UTC) Subject: [dpdk-stable] patch 'test/distributor: replace sprintf with strlcpy' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/01/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches can be viewed on the 18.11 branch at: https://github.com/kevintraynor/dpdk-stable-queue.git Thanks. Kevin Traynor --- >From 3a88e8f3fbcd7ea4347dce8dabf677e99cc596fc Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Thu, 14 Feb 2019 09:45:49 +0000 Subject: [PATCH] test/distributor: replace sprintf with strlcpy [ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ] sprintf function is not secure as it doesn't check the length of string. replaced sprintf with strlcpy. Fixes: f74df2c57e ("test/distributor: test single and burst API") Signed-off-by: Pallantla Poornima Acked-by: David Hunt --- test/test/test_distributor.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 98919ec0c..da3348fd1 100644 --- a/test/test/test_distributor.c +++ b/test/test/test_distributor.c @@ -12,4 +12,5 @@ #include #include +#include #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */ @@ -643,7 +644,9 @@ test_distributor(void) worker_params.dist = dist[i]; if (i) - sprintf(worker_params.name, "burst"); + strlcpy(worker_params.name, "burst", + sizeof(worker_params.name)); else - sprintf(worker_params.name, "single"); + strlcpy(worker_params.name, "single", + sizeof(worker_params.name)); rte_eal_mp_remote_launch(handle_work, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-25 16:37:48.949462737 +0100 +++ 0051-test-distributor-replace-sprintf-with-strlcpy.patch 2019-04-25 16:37:46.768294423 +0100 @@ -1 +1 @@ -From 7ab0770233ed5bb89845abf6b978ef15b2520bd8 Mon Sep 17 00:00:00 2001 +From 3a88e8f3fbcd7ea4347dce8dabf677e99cc596fc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - app/test/test_distributor.c | 7 +++++-- + test/test/test_distributor.c | 7 +++++-- @@ -18 +19 @@ -diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c +diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c @@ -20,2 +21,2 @@ ---- a/app/test/test_distributor.c -+++ b/app/test/test_distributor.c +--- a/test/test/test_distributor.c ++++ b/test/test/test_distributor.c