patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/i40e: fix scattered Rx enabling' has been queued to LTS release 18.11.2
Date: Tue, 30 Apr 2019 18:01:14 +0100	[thread overview]
Message-ID: <20190430170133.2331-19-ktraynor@redhat.com> (raw)
In-Reply-To: <20190430170133.2331-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on a temporary branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
From f7763164455b458fce6dc32145e871f4f912b080 Mon Sep 17 00:00:00 2001
From: Qi Zhang <qi.z.zhang@intel.com>
Date: Wed, 27 Mar 2019 19:00:05 +0800
Subject: [PATCH] net/i40e: fix scattered Rx enabling

[ upstream commit 756cea41e9b8108ee8887b63abc357c1f678f480 ]

No need to add additional vlan tag size for max packet size, since
for i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already
includes the vlan header size.

Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup")
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Fixes: c1715402df8f ("i40evf: fix jumbo frame support")

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 +--
 drivers/net/i40e/i40e_rxtx.c      | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 100e71cc8..ae0812bff 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1725,7 +1725,6 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct i40e_rx_queue *rxq)
 
 	if ((dev_data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_SCATTER) ||
-	    (rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) {
+	    rxq->max_pkt_len > buf_size)
 		dev_data->scattered_rx = 1;
-	}
 
 	return 0;
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 8f727fae6..58ed8145d 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1719,5 +1719,5 @@ i40e_dev_rx_queue_setup_runtime(struct rte_eth_dev *dev,
 			   RTE_PKTMBUF_HEADROOM);
 	int use_scattered_rx =
-		((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size);
+		(rxq->max_pkt_len > buf_size);
 
 	if (i40e_rx_queue_init(rxq) != I40E_SUCCESS) {
@@ -2709,7 +2709,6 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq)
 
 	/* Check if scattered RX needs to be used. */
-	if ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) {
+	if (rxq->max_pkt_len > buf_size)
 		dev_data->scattered_rx = 1;
-	}
 
 	/* Init the RX tail regieter. */
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-30 17:58:14.717553037 +0100
+++ 0019-net-i40e-fix-scattered-Rx-enabling.patch	2019-04-30 17:58:13.798139964 +0100
@@ -1 +1 @@
-From 756cea41e9b8108ee8887b63abc357c1f678f480 Mon Sep 17 00:00:00 2001
+From f7763164455b458fce6dc32145e871f4f912b080 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 756cea41e9b8108ee8887b63abc357c1f678f480 ]
+
@@ -13 +14,0 @@
-Cc: stable@dpdk.org
@@ -22 +23 @@
-index add7b2223..87c45f278 100644
+index 100e71cc8..ae0812bff 100644
@@ -25 +26 @@
-@@ -1786,7 +1786,6 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct i40e_rx_queue *rxq)
+@@ -1725,7 +1725,6 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct i40e_rx_queue *rxq)

  parent reply	other threads:[~2019-04-30 17:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 17:00 [dpdk-stable] patch 'net/mlx5: fix memory event on secondary process' " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx4: change device reference for " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx: remove debug messages on datapath' " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx5: fix external memory registration' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/sfc: improve TSO header length check in EFX datapath' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/sfc: improve TSO header length check in EF10 " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net: fix Tx VLAN flag for offload emulation' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix Tx VLAN and QinQ dependency' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix Tx QinQ set' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'table: fix arm64 hash function selection' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix file descriptor check' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix potential integer overflow' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: check return value' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix memory leak' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix mempool free on exit' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix hex string parser support for flow API' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix return value check' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/bnxt: fix big endian build' " Kevin Traynor
2019-04-30 17:01 ` Kevin Traynor [this message]
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: fix spelling in testpmd guide' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: add flow API to qede NIC features' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: accept experimental symbol promotion' " Kevin Traynor
2019-05-02  7:25   ` David Marchand
2019-05-02  8:01     ` Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: skip meson build for missing compilers' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: support older compilers with meson test' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'examples/l2fwd-cat: fix build on FreeBSD' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'build: use default flags for default Arm machine' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'drivers/event: disable OcteonTx for buggy Arm compilers' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'examples/fips_validation: fix CMAC test' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: add missing algorithms for AESNI-MB PMD' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix shared descriptor endianness' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix total length in auth only s/g' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix memory leak and illegal access' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: fix missing asymmetric crypto table' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/crypto-perf: check range of socket id' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/dpaa: fix session destroy' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'kni: fix build with Linux 5.1' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'kni: fix type for MAC address' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'mbuf: update Tx VLAN and QinQ flags documentation' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430170133.2331-19-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).