From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 76465A0679 for ; Tue, 30 Apr 2019 19:02:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D3BE5B20; Tue, 30 Apr 2019 19:02:32 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1E10E58CB for ; Tue, 30 Apr 2019 19:02:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 880B4319936E; Tue, 30 Apr 2019 17:02:29 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-211.ams2.redhat.com [10.36.117.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABC2717CF9; Tue, 30 Apr 2019 17:02:28 +0000 (UTC) From: Kevin Traynor To: Marko Kovacevic Cc: dpdk stable Date: Tue, 30 Apr 2019 18:01:23 +0100 Message-Id: <20190430170133.2331-28-ktraynor@redhat.com> In-Reply-To: <20190430170133.2331-1-ktraynor@redhat.com> References: <20190430170133.2331-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 30 Apr 2019 17:02:29 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/fips_validation: fix CMAC test' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/07/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches can be viewed on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue.git Thanks. Kevin Traynor --- >From 894eae3b831e752cfe4c2c2343f453a7291e10fa Mon Sep 17 00:00:00 2001 From: Marko Kovacevic Date: Mon, 15 Apr 2019 16:04:48 +0100 Subject: [PATCH] examples/fips_validation: fix CMAC test [ upstream commit 083a277754f664d6f5d3af166f1f45ae0cb32cc3 ] As a result of the cmac test running the test where PT len is 65536 it should give a result back to the user USER1: Error -1: Prepare op USER1: PT len 65536 as this MSG len is not supported. Issue was that the application was not freeing the op properly after a while causing the app to fail. CRYPTODEV: rte_cryptodev_sym_session_create() line 1340: couldn't get object from session mempool USER1: Error -12: test block USER1: Error -12: Failed test CMAC/req/CMAC.req Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing") Signed-off-by: Marko Kovacevic --- examples/fips_validation/main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index e7559c633..40785decb 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -807,5 +807,5 @@ fips_run_test(void) RTE_LOG(ERR, USER1, "Error %i: Init session\n", ret); - return ret; + goto exit; } @@ -814,10 +814,11 @@ fips_run_test(void) RTE_LOG(ERR, USER1, "Error %i: Prepare op\n", ret); - return ret; + goto exit; } if (rte_cryptodev_enqueue_burst(env.dev_id, 0, &env.op, 1) < 1) { RTE_LOG(ERR, USER1, "Error: Failed enqueue\n"); - return ret; + ret = -1; + goto exit; } @@ -831,4 +832,5 @@ fips_run_test(void) vec.status = env.op->status; +exit: rte_cryptodev_sym_session_clear(env.dev_id, env.sess); rte_cryptodev_sym_session_free(env.sess); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-30 17:58:15.142556804 +0100 +++ 0028-examples-fips_validation-fix-CMAC-test.patch 2019-04-30 17:58:13.803139861 +0100 @@ -1 +1 @@ -From 083a277754f664d6f5d3af166f1f45ae0cb32cc3 Mon Sep 17 00:00:00 2001 +From 894eae3b831e752cfe4c2c2343f453a7291e10fa Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 083a277754f664d6f5d3af166f1f45ae0cb32cc3 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 5e3d5baa8..aef45055e 100644 +index e7559c633..40785decb 100644 @@ -30 +31 @@ -@@ -950,5 +950,5 @@ fips_run_test(void) +@@ -807,5 +807,5 @@ fips_run_test(void) @@ -37 +38 @@ -@@ -957,10 +957,11 @@ fips_run_test(void) +@@ -814,10 +814,11 @@ fips_run_test(void) @@ -51 +52 @@ -@@ -974,4 +975,5 @@ fips_run_test(void) +@@ -831,4 +832,5 @@ fips_run_test(void)