patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Bernard Iremonger <bernard.iremonger@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'app/testpmd: fix Tx QinQ set' has been queued to LTS release 18.11.2
Date: Tue, 30 Apr 2019 18:01:04 +0100	[thread overview]
Message-ID: <20190430170133.2331-9-ktraynor@redhat.com> (raw)
In-Reply-To: <20190430170133.2331-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on a temporary branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
From c469a27cf315c2caa9ab9f01fd3ed8ad649905bf Mon Sep 17 00:00:00 2001
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date: Fri, 5 Apr 2019 07:36:24 +0000
Subject: [PATCH] app/testpmd: fix Tx QinQ set

[ upstream commit 6b1ad5181c7dc10119238e8798bbc96c9d83d1fc ]

Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.

Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 app/test-pmd/config.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 5397acbd1..4004e3a49 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3000,5 +3000,6 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)
 
 	tx_vlan_reset(port_id);
-	ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_QINQ_INSERT;
+	ports[port_id].dev_conf.txmode.offloads |= (DEV_TX_OFFLOAD_VLAN_INSERT |
+						    DEV_TX_OFFLOAD_QINQ_INSERT);
 	ports[port_id].tx_vlan_id = vlan_id;
 	ports[port_id].tx_vlan_id_outer = vlan_id_outer;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-30 17:58:14.244429207 +0100
+++ 0009-app-testpmd-fix-Tx-QinQ-set.patch	2019-04-30 17:58:13.764140660 +0100
@@ -1 +1 @@
-From 6b1ad5181c7dc10119238e8798bbc96c9d83d1fc Mon Sep 17 00:00:00 2001
+From c469a27cf315c2caa9ab9f01fd3ed8ad649905bf Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6b1ad5181c7dc10119238e8798bbc96c9d83d1fc ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -21 +22 @@
-index 010e26d4c..f9cb12964 100644
+index 5397acbd1..4004e3a49 100644
@@ -24 +25 @@
-@@ -3007,5 +3007,6 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)
+@@ -3000,5 +3000,6 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)

  parent reply	other threads:[~2019-04-30 17:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 17:00 [dpdk-stable] patch 'net/mlx5: fix memory event on secondary process' " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx4: change device reference for " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx: remove debug messages on datapath' " Kevin Traynor
2019-04-30 17:00 ` [dpdk-stable] patch 'net/mlx5: fix external memory registration' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/sfc: improve TSO header length check in EFX datapath' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/sfc: improve TSO header length check in EF10 " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net: fix Tx VLAN flag for offload emulation' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix Tx VLAN and QinQ dependency' " Kevin Traynor
2019-04-30 17:01 ` Kevin Traynor [this message]
2019-04-30 17:01 ` [dpdk-stable] patch 'table: fix arm64 hash function selection' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix file descriptor check' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix potential integer overflow' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: check return value' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/nfp: fix memory leak' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix mempool free on exit' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix hex string parser support for flow API' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/testpmd: fix return value check' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/bnxt: fix big endian build' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'net/i40e: fix scattered Rx enabling' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: fix spelling in testpmd guide' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: add flow API to qede NIC features' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: accept experimental symbol promotion' " Kevin Traynor
2019-05-02  7:25   ` David Marchand
2019-05-02  8:01     ` Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: skip meson build for missing compilers' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'devtools: support older compilers with meson test' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'examples/l2fwd-cat: fix build on FreeBSD' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'build: use default flags for default Arm machine' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'drivers/event: disable OcteonTx for buggy Arm compilers' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'examples/fips_validation: fix CMAC test' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: add missing algorithms for AESNI-MB PMD' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix shared descriptor endianness' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix total length in auth only s/g' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/caam_jr: fix memory leak and illegal access' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'doc: fix missing asymmetric crypto table' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'app/crypto-perf: check range of socket id' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'crypto/dpaa: fix session destroy' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'kni: fix build with Linux 5.1' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'kni: fix type for MAC address' " Kevin Traynor
2019-04-30 17:01 ` [dpdk-stable] patch 'mbuf: update Tx VLAN and QinQ flags documentation' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430170133.2331-9-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bernard.iremonger@intel.com \
    --cc=ferruh.yigit@intel.com \
    --cc=ndabilpuram@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).