From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 93F5AA0096 for ; Tue, 7 May 2019 23:11:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AF26343C; Tue, 7 May 2019 23:11:52 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 02CE93DC for ; Tue, 7 May 2019 23:11:48 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 May 2019 00:11:46 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x47LBggU019137; Wed, 8 May 2019 00:11:43 +0300 From: Yongseok Koh To: jerinj@marvell.com, thomas@monjalon.net Cc: dev@dpdk.org, bruce.richardson@intel.com, pbhagavatula@marvell.com, shahafs@mellanox.com, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, stable@dpdk.org, Dharmik Thakkar Date: Tue, 7 May 2019 14:11:40 -0700 Message-Id: <20190507211140.43569-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502015806.41497-1-yskoh@mellanox.com> References: <20190502015806.41497-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH v3] build: disable armv8 crypto extension X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. It is known that not all the armv8 platforms have the crypto extension. For example, Mellanox BlueField has a variant which doesn't have it. If crypto enabled binary runs on such a platform, rte_eal_init() fails. '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will generate the crypto instructions only when crypto intrinsics are used. For the devices supporting 8.2 crypto or newer, compiler could generate such instructions beyond intrinsics or asm code. For example, compiler can generate 3-way exclusive OR instructions if sha3 is supported. However, it has to be enabled by adding '+sha3' as of today. In DPDK, armv8 cryptodev is the only one which requires the crypto support. As it even uses external library of Marvell which is compiled out of DPDK with crypto support and there's run-time check for required cpuflags, crypto support can be disabled in DPDK. Cc: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Jerin Jacob Tested-by: Dharmik Thakkar --- v3: * announce removal of the flag in release note v2: * disable crypto support instead of having a build config config/arm/meson.build | 2 +- doc/guides/rel_notes/release_19_05.rst | 2 ++ mk/machine/armv8a/rte.vars.mk | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 7fa6ed3105..abc8cf346c 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -74,7 +74,7 @@ flags_octeontx2_extra = [ ['RTE_USE_C11_MEM_MODEL', true]] machine_args_generic = [ - ['default', ['-march=armv8-a+crc+crypto']], + ['default', ['-march=armv8-a+crc']], ['native', ['-march=native']], ['0xd03', ['-mcpu=cortex-a53']], ['0xd04', ['-mcpu=cortex-a35']], diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 5044ac7df1..0d35f25094 100644 --- a/doc/guides/rel_notes/release_19_05.rst +++ b/doc/guides/rel_notes/release_19_05.rst @@ -234,6 +234,8 @@ Removed Items Also, make sure to start the actual text at the margin. ========================================================= +* build: armv8 crypto extension is disabled. + API Changes ----------- diff --git a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk index 8252efbb7b..5e3ffc3adf 100644 --- a/mk/machine/armv8a/rte.vars.mk +++ b/mk/machine/armv8a/rte.vars.mk @@ -28,4 +28,4 @@ # CPU_LDFLAGS = # CPU_ASFLAGS = -MACHINE_CFLAGS += -march=armv8-a+crc+crypto +MACHINE_CFLAGS += -march=armv8-a+crc -- 2.21.0