From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1D0C7A0096 for ; Wed, 8 May 2019 12:16:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11A982BD5; Wed, 8 May 2019 12:16:40 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 238494C8F for ; Wed, 8 May 2019 12:16:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8ABF2C04FF86; Wed, 8 May 2019 10:16:37 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D4C84123; Wed, 8 May 2019 10:16:36 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: Amr Mokhtar , dpdk stable Date: Wed, 8 May 2019 11:15:09 +0100 Message-Id: <20190508101534.8984-27-ktraynor@redhat.com> In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com> References: <20190508101534.8984-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 08 May 2019 10:16:37 +0000 (UTC) Subject: [dpdk-stable] patch 'app/bbdev: replace sprintf with snprintf or strlcpy' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/13/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/1fa39537a7b8c6df6de07fa2a245be93abd8a581 Thanks. Kevin Traynor --- >From 1fa39537a7b8c6df6de07fa2a245be93abd8a581 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Tue, 9 Apr 2019 14:05:40 +0100 Subject: [PATCH] app/bbdev: replace sprintf with snprintf or strlcpy [ upstream commit cde417155fa3dd351c230731ddfc8db3f57db227 ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf and strlcpy is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Signed-off-by: Pallantla Poornima Acked-by: Amr Mokhtar --- app/test-bbdev/test_bbdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c index a914817bc..137c74cde 100644 --- a/app/test-bbdev/test_bbdev.c +++ b/app/test-bbdev/test_bbdev.c @@ -15,4 +15,6 @@ #include #include +#include +#include #include "main.h" @@ -789,5 +791,5 @@ test_bbdev_driver_init(void) /* Initialize the maximum amount of devices */ do { - sprintf(name_tmp, "%s%i", "name_", num_devs); + snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs); dev2 = rte_bbdev_allocate(name_tmp); TEST_ASSERT(dev2 != NULL, @@ -796,5 +798,5 @@ test_bbdev_driver_init(void) } while (num_devs < (RTE_BBDEV_MAX_DEVS - 1)); - sprintf(name_tmp, "%s%i", "name_", num_devs); + snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs); dev2 = rte_bbdev_allocate(name_tmp); TEST_ASSERT(dev2 == NULL, "Failed to initialize bbdev driver number %d " @@ -805,5 +807,5 @@ test_bbdev_driver_init(void) while (num_devs >= num_devs_tmp) { - sprintf(name_tmp, "%s%i", "name_", num_devs); + snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs); dev2 = rte_bbdev_get_named_dev(name_tmp); TEST_ASSERT_SUCCESS(rte_bbdev_release(dev2), @@ -826,5 +828,5 @@ test_bbdev_driver_init(void) "Failed to uninitialize bbdev driver with NULL bbdev"); - sprintf(name_tmp, "%s", "invalid_name"); + strlcpy(name_tmp, "invalid_name", sizeof(name_tmp)); dev2 = rte_bbdev_get_named_dev(name_tmp); TEST_ASSERT_FAIL(rte_bbdev_release(dev2), -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 11:05:07.181621673 +0100 +++ 0027-app-bbdev-replace-sprintf-with-snprintf-or-strlcpy.patch 2019-05-08 11:05:05.811933138 +0100 @@ -1 +1 @@ -From cde417155fa3dd351c230731ddfc8db3f57db227 Mon Sep 17 00:00:00 2001 +From 1fa39537a7b8c6df6de07fa2a245be93abd8a581 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cde417155fa3dd351c230731ddfc8db3f57db227 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org