From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81484A0096 for ; Wed, 8 May 2019 12:16:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 742792BD5; Wed, 8 May 2019 12:16:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A5F134CA0 for ; Wed, 8 May 2019 12:16:44 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 18E333004141; Wed, 8 May 2019 10:16:44 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07A69F6C9; Wed, 8 May 2019 10:16:42 +0000 (UTC) From: Kevin Traynor To: Reshma Pattan Cc: David Hunt , dpdk stable Date: Wed, 8 May 2019 11:15:14 +0100 Message-Id: <20190508101534.8984-32-ktraynor@redhat.com> In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com> References: <20190508101534.8984-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 08 May 2019 10:16:44 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/power: fix string overflow' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/13/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/45790bfbd3c2ed64596e25fea9b3229a5ad096ab Thanks. Kevin Traynor --- >From 45790bfbd3c2ed64596e25fea9b3229a5ad096ab Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Wed, 10 Apr 2019 15:54:31 +0100 Subject: [PATCH] examples/power: fix string overflow [ upstream commit 57fad3e25fee6400af07a917e876ef8e4ee0e653 ] Use strlcpy instead of strcpy to fix string overflow. Coverity issue: 337671 Fixes: a63504a90f ("examples/power: add JSON string handling") Signed-off-by: Reshma Pattan Acked-by: David Hunt --- examples/vm_power_manager/channel_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c index d45d8f74b..954bdf787 100644 --- a/examples/vm_power_manager/channel_monitor.c +++ b/examples/vm_power_manager/channel_monitor.c @@ -159,5 +159,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt) return ret; } else if (!strcmp(key, "name")) { - strcpy(pkt->vm_name, json_string_value(value)); + strlcpy(pkt->vm_name, json_string_value(value), + sizeof(pkt->vm_name)); } else if (!strcmp(key, "command")) { char command[32]; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 11:05:07.428019816 +0100 +++ 0032-examples-power-fix-string-overflow.patch 2019-05-08 11:05:05.815933054 +0100 @@ -1 +1 @@ -From 57fad3e25fee6400af07a917e876ef8e4ee0e653 Mon Sep 17 00:00:00 2001 +From 45790bfbd3c2ed64596e25fea9b3229a5ad096ab Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 57fad3e25fee6400af07a917e876ef8e4ee0e653 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index bc5679d4b..971e4f2bc 100644 +index d45d8f74b..954bdf787 100644 @@ -22 +23 @@ -@@ -160,5 +160,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt) +@@ -159,5 +159,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)