From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2C7A2A0096 for ; Wed, 8 May 2019 12:16:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C4C32862; Wed, 8 May 2019 12:16:59 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 57DAB44C3 for ; Wed, 8 May 2019 12:16:57 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF165300180A; Wed, 8 May 2019 10:16:56 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id E34541A267; Wed, 8 May 2019 10:16:55 +0000 (UTC) From: Kevin Traynor To: Fiona Trahe Cc: dpdk stable Date: Wed, 8 May 2019 11:15:23 +0100 Message-Id: <20190508101534.8984-41-ktraynor@redhat.com> In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com> References: <20190508101534.8984-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 08 May 2019 10:16:56 +0000 (UTC) Subject: [dpdk-stable] patch 'crypto/qat: fix null cipher algo for non 8-byte multiple' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/13/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/c7fb431ae3f658fdd87e834e3c5aedc87d3c715c Thanks. Kevin Traynor --- >From c7fb431ae3f658fdd87e834e3c5aedc87d3c715c Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Fri, 26 Apr 2019 20:28:03 +0100 Subject: [PATCH] crypto/qat: fix null cipher algo for non 8-byte multiple [ upstream commit 20f1cb1aaf77535d11526c5a1c165eeeeddeff6a ] NULL cipher algo of 4-byte multiple and other sizes caused firmware hang due to use of wrong mode. Changed from ECB mode to CTR mode to fix. Fixes: 98f060891615 ("crypto/qat: add symmetric session file") Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym_session.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 4d7ec01d4..e147572e1 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -243,5 +243,6 @@ qat_sym_session_configure_cipher(struct rte_cryptodev *dev, break; case RTE_CRYPTO_CIPHER_NULL: - session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE; + session->qat_cipher_alg = ICP_QAT_HW_CIPHER_ALGO_NULL; + session->qat_mode = ICP_QAT_HW_CIPHER_CTR_MODE; break; case RTE_CRYPTO_CIPHER_KASUMI_F8: -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 11:05:07.871645389 +0100 +++ 0041-crypto-qat-fix-null-cipher-algo-for-non-8-byte-multi.patch 2019-05-08 11:05:05.850932322 +0100 @@ -1 +1 @@ -From 20f1cb1aaf77535d11526c5a1c165eeeeddeff6a Mon Sep 17 00:00:00 2001 +From c7fb431ae3f658fdd87e834e3c5aedc87d3c715c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 20f1cb1aaf77535d11526c5a1c165eeeeddeff6a ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 5cc86f554..f66175d03 100644 +index 4d7ec01d4..e147572e1 100644