From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EEF1FA0096 for ; Wed, 8 May 2019 12:17:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E58A637B7; Wed, 8 May 2019 12:17:06 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6C6794C8D for ; Wed, 8 May 2019 12:17:05 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D66B8C060200; Wed, 8 May 2019 10:17:04 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CB0F16BF6; Wed, 8 May 2019 10:17:03 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: dpdk stable Date: Wed, 8 May 2019 11:15:30 +0100 Message-Id: <20190508101534.8984-48-ktraynor@redhat.com> In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com> References: <20190508101534.8984-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 08 May 2019 10:17:04 +0000 (UTC) Subject: [dpdk-stable] patch 'raw/skeleton: fix warnings with GCC 9' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/13/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/edac099a3f0a1e5c35b04f75e71209c8972bd431 Thanks. Kevin Traynor --- >From edac099a3f0a1e5c35b04f75e71209c8972bd431 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 1 May 2019 20:50:13 +0100 Subject: [PATCH] raw/skeleton: fix warnings with GCC 9 [ upstream commit 3a66890a8ada0a35f9292b1b6ce0326a5c3ce384 ] GCC9 gives warnings if the parameter passed to printf for "%s" could be NULL, so we need to add checks in some cases to ensure that is not the case. Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") Signed-off-by: Bruce Richardson --- drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c index d7630fc69..63f2b9a09 100644 --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c @@ -706,4 +706,7 @@ skeleton_rawdev_probe(struct rte_vdev_device *vdev) name = rte_vdev_device_name(vdev); + if (name == NULL) + return -EINVAL; + /* More than one instance is not supported */ if (skeldev_init_once) { @@ -741,4 +744,6 @@ skeleton_rawdev_remove(struct rte_vdev_device *vdev) name = rte_vdev_device_name(vdev); + if (name == NULL) + return -1; SKELETON_PMD_INFO("Closing %s on NUMA node %d", name, rte_socket_id()); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 11:05:08.197110777 +0100 +++ 0048-raw-skeleton-fix-warnings-with-GCC-9.patch 2019-05-08 11:05:05.859932134 +0100 @@ -1 +1 @@ -From 3a66890a8ada0a35f9292b1b6ce0326a5c3ce384 Mon Sep 17 00:00:00 2001 +From edac099a3f0a1e5c35b04f75e71209c8972bd431 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3a66890a8ada0a35f9292b1b6ce0326a5c3ce384 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org