patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Rasesh Mody <rmody@marvell.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/bnx2x: fix optic module verification' has been queued to LTS release 18.11.2
Date: Wed,  8 May 2019 11:14:48 +0100	[thread overview]
Message-ID: <20190508101534.8984-6-ktraynor@redhat.com> (raw)
In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/90baad67611a2ddfd9731cb1d441ea13f7014020

Thanks.

Kevin Traynor

---
From 90baad67611a2ddfd9731cb1d441ea13f7014020 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rmody@marvell.com>
Date: Thu, 11 Apr 2019 18:47:42 -0700
Subject: [PATCH] net/bnx2x: fix optic module verification

[ upstream commit 5a6af6baa8c64ab31bd457b12be1f5173194bec6 ]

Enable the optic module vendor and part number verification from driver
by setting appropriate flags. Link handling module in conjunction with
FW performs optic module verification.

Without this fix the SFP is powered down and the link doesn't come up,
if module verification is enforced in nvram setting.

Fixes: 540a211084a7 ("bnx2x: driver core")

Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 drivers/net/bnx2x/bnx2x.c | 21 +++++++++++++++++++++
 drivers/net/bnx2x/bnx2x.h |  2 ++
 2 files changed, 23 insertions(+)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index f32db6d12..3e705c7a1 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -8104,4 +8104,25 @@ static int bnx2x_get_shmem_info(struct bnx2x_softc *sc)
 	}
 
+	val = sc->devinfo.bc_ver >> 8;
+	if (val < BNX2X_BC_VER) {
+		/* for now only warn later we might need to enforce this */
+		PMD_DRV_LOG(NOTICE, sc, "This driver needs bc_ver %X but found %X, please upgrade BC\n",
+			    BNX2X_BC_VER, val);
+	}
+	sc->link_params.feature_config_flags |=
+				(val >= REQ_BC_VER_4_VRFY_FIRST_PHY_OPT_MDL) ?
+				ELINK_FEATURE_CONFIG_BC_SUPPORTS_OPT_MDL_VRFY :
+				0;
+
+	sc->link_params.feature_config_flags |=
+		(val >= REQ_BC_VER_4_VRFY_SPECIFIC_PHY_OPT_MDL) ?
+		ELINK_FEATURE_CONFIG_BC_SUPPORTS_DUAL_PHY_OPT_MDL_VRFY : 0;
+	sc->link_params.feature_config_flags |=
+		(val >= REQ_BC_VER_4_VRFY_AFEX_SUPPORTED) ?
+		ELINK_FEATURE_CONFIG_BC_SUPPORTS_AFEX : 0;
+	sc->link_params.feature_config_flags |=
+		(val >= REQ_BC_VER_4_SFP_TX_DISABLE_SUPPORTED) ?
+		ELINK_FEATURE_CONFIG_BC_SUPPORTS_SFP_TX_DISABLED : 0;
+
 	/* get the initial value of the link params */
 	sc->link_params.multi_phy_config =
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index bb8031001..ef1688ff3 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -120,4 +120,6 @@ int bnx2x_ilog2(int x)
 #endif
 
+#define BNX2X_BC_VER		0x040200
+
 #include "ecore_sp.h"
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:06.161360145 +0100
+++ 0006-net-bnx2x-fix-optic-module-verification.patch	2019-05-08 11:05:05.760934205 +0100
@@ -1 +1 @@
-From 5a6af6baa8c64ab31bd457b12be1f5173194bec6 Mon Sep 17 00:00:00 2001
+From 90baad67611a2ddfd9731cb1d441ea13f7014020 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5a6af6baa8c64ab31bd457b12be1f5173194bec6 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org

  parent reply	other threads:[~2019-05-08 10:15 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 10:14 [dpdk-stable] patch 'net/bnx2x: fix MTU for jumbo frame' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/bnx2x: fix memory leak' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/bnx2x: fix ramrod timeout' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/bnx2x: fix DMAE " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/bnx2x: fix race for periodic flags' " Kevin Traynor
2019-05-08 10:14 ` Kevin Traynor [this message]
2019-05-08 10:14 ` [dpdk-stable] patch 'net/mlx5: fix RSS validation function' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/enetc: fix SMMU unhandled context fault' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/enetc: fix big endian build and buffer allocation' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/enetc: fix crash at high speed traffic' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'app/testpmd: set fixed flag for exact link speed' " Kevin Traynor
2019-05-08 10:20   ` Andrew Rybchenko
2019-05-08 10:26     ` Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/iavf: fix info get' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'crypto/virtio: fix IV offset' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/virtio: fix buffer leak on VLAN insert' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'net/virtio-user: fix return value check' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'vhost: fix device leak on connection add failure' " Kevin Traynor
2019-05-08 10:14 ` [dpdk-stable] patch 'vhost: fix null pointer checking' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'vhost: fix passing destroyed device to destroy callback' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'vhost: fix silent queue enabling with legacy guests' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/virtio: fix dangling pointer on failure' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/i40e: fix logging on VF close' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/mlx5: fix memory region cleanup' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/mlx4: " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/cxgbe: fix colliding function names' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/tap: fix multi process reply buffer' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'bus/vmbus: fix resource leak on error' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'app/bbdev: replace sprintf with snprintf or strlcpy' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'power: fix thread-safety environment modification' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix resource leak' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix unreachable VF MAC init' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix string null termination' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix string overflow' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix overflowed value' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/power: fix build with some disabled PMDs' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'examples/vhost_scsi: fix null-check for parameter' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/i40e: fix dereference before null check in mbuf release' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/i40e: fix dereference before check when getting EEPROM' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'app/testpmd: fix variable use before null check' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'bitrate: fix unchecked return value' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'doc: fix heading levels in bbdev test guide' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'crypto/qat: fix null cipher algo for non 8-byte multiple' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'eventdev: fix crypto adapter' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'crypto/snow3g: add to meson build' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'crypto/kasumi: fix dependency check' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'crypto/zuc: " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'net/ixgbe: fix warning with GCC 9' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'bus/fslmc: " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'raw/skeleton: fix warnings " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'raw/dpaa2_cmdif: " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'build: fix meson binutils workaround' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'build: fix crash by disabling AVX512 with binutils 2.31' " Kevin Traynor
2019-05-08 10:15 ` [dpdk-stable] patch 'build: fix ninja install on FreeBSD' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508101534.8984-6-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).