From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 80291A0096 for ; Wed, 8 May 2019 18:02:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7020C378B; Wed, 8 May 2019 18:02:53 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8026B4C90 for ; Wed, 8 May 2019 18:02:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E30EF307D974; Wed, 8 May 2019 16:02:51 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id B059F60C82; Wed, 8 May 2019 16:02:50 +0000 (UTC) From: Kevin Traynor To: Herakliusz Lipiec Cc: Keith Wiles , dpdk stable Date: Wed, 8 May 2019 17:02:07 +0100 Message-Id: <20190508160233.2648-10-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 08 May 2019 16:02:51 +0000 (UTC) Subject: [dpdk-stable] patch 'net/tap: fix memory leak on IPC request' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/8f3e73d8c22ca3ace05b6d82482f6258f0b089b8 Thanks. Kevin Traynor --- >From 8f3e73d8c22ca3ace05b6d82482f6258f0b089b8 Mon Sep 17 00:00:00 2001 From: Herakliusz Lipiec Date: Thu, 25 Apr 2019 13:48:17 +0100 Subject: [PATCH] net/tap: fix memory leak on IPC request [ upstream commit 388e061ecfe42446d51d8a90dabce6b43fd76167 ] When sending synchronous IPC requests, the caller must free the response buffer if the request was successful and reply is no longer needed. Fix the code to correctly use the IPC API. Bugzilla ID: 228 Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Signed-off-by: Herakliusz Lipiec Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 551f4d3a2..292657d0b 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -2089,5 +2089,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev) for (queue = 0; queue < reply_param->txq_count; queue++) process_private->txq_fds[queue] = reply->fds[fd_iterator++]; - + free(reply); return 0; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:57.999655182 +0100 +++ 0010-net-tap-fix-memory-leak-on-IPC-request.patch 2019-05-08 16:33:57.365579654 +0100 @@ -1 +1 @@ -From 388e061ecfe42446d51d8a90dabce6b43fd76167 Mon Sep 17 00:00:00 2001 +From 8f3e73d8c22ca3ace05b6d82482f6258f0b089b8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 388e061ecfe42446d51d8a90dabce6b43fd76167 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 7f74b5dc9..f8a4169c5 100644 +index 551f4d3a2..292657d0b 100644 @@ -25 +26 @@ -@@ -2119,5 +2119,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev) +@@ -2089,5 +2089,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)