From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8BA03A0096 for ; Wed, 8 May 2019 18:02:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83331DE3; Wed, 8 May 2019 18:02:55 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DDD4644C3 for ; Wed, 8 May 2019 18:02:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FB0D81106; Wed, 8 May 2019 16:02:53 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F7A660C82; Wed, 8 May 2019 16:02:52 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: Rami Rosen , dpdk stable Date: Wed, 8 May 2019 17:02:08 +0100 Message-Id: <20190508160233.2648-11-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 08 May 2019 16:02:53 +0000 (UTC) Subject: [dpdk-stable] patch 'ipc: fix send error handling' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/6c4a669bdfc38dd115f5cfe84b03da58770bfda0 Thanks. Kevin Traynor --- >From 6c4a669bdfc38dd115f5cfe84b03da58770bfda0 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 26 Apr 2019 11:27:17 +0100 Subject: [PATCH] ipc: fix send error handling [ upstream commit 535113907f23134375b18f40b6642a963ec50141 ] According to manpage, ENOBUFS error indicates that either the input or the output queue is full. This should be considered an error, but it is treated as an "ignore" condition. Fix the code to report an error instead. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Signed-off-by: Anatoly Burakov Acked-by: Rami Rosen --- lib/librte_eal/common/eal_common_proc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index ef5eddbea..8586474a2 100644 --- a/lib/librte_eal/common/eal_common_proc.c +++ b/lib/librte_eal/common/eal_common_proc.c @@ -679,9 +679,4 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type) return 0; } - if (errno == ENOBUFS) { - RTE_LOG(ERR, EAL, "Peer cannot receive message %s\n", - dst_path); - return 0; - } RTE_LOG(ERR, EAL, "failed to send to (%s) due to %s\n", dst_path, strerror(errno)); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:58.045663685 +0100 +++ 0011-ipc-fix-send-error-handling.patch 2019-05-08 16:33:57.365579654 +0100 @@ -1 +1 @@ -From 535113907f23134375b18f40b6642a963ec50141 Mon Sep 17 00:00:00 2001 +From 6c4a669bdfc38dd115f5cfe84b03da58770bfda0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 535113907f23134375b18f40b6642a963ec50141 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org