From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B5B84A0096 for ; Wed, 8 May 2019 18:02:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9F5444C3; Wed, 8 May 2019 18:02:57 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 510784C77 for ; Wed, 8 May 2019 18:02:56 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBA48307D766; Wed, 8 May 2019 16:02:55 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id E264F60C82; Wed, 8 May 2019 16:02:54 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: dpdk stable Date: Wed, 8 May 2019 17:02:10 +0100 Message-Id: <20190508160233.2648-13-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 08 May 2019 16:02:55 +0000 (UTC) Subject: [dpdk-stable] patch 'ipc: handle more invalid parameter cases' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/0a784ce51f4fbcb7c0cb9f3875c2082fa52639f1 Thanks. Kevin Traynor --- >From 0a784ce51f4fbcb7c0cb9f3875c2082fa52639f1 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Mon, 29 Apr 2019 14:59:28 +0100 Subject: [PATCH] ipc: handle more invalid parameter cases [ upstream commit 6e5d779ecb9acd034f90af1de8f9416832d663d0 ] Length of buffer and number of fd's to send are signed values, so they can be negative, but the API doesn't check for that. Fix it by checking for negative values as well. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_proc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index 6ffd47686..d098803b1 100644 --- a/lib/librte_eal/common/eal_common_proc.c +++ b/lib/librte_eal/common/eal_common_proc.c @@ -762,4 +762,16 @@ check_input(const struct rte_mp_msg *msg) return false; + if (msg->len_param < 0) { + RTE_LOG(ERR, EAL, "Message data length is negative\n"); + rte_errno = EINVAL; + return false; + } + + if (msg->num_fds < 0) { + RTE_LOG(ERR, EAL, "Number of fd's is negative\n"); + rte_errno = EINVAL; + return false; + } + if (msg->len_param > RTE_MP_MAX_PARAM_LEN) { RTE_LOG(ERR, EAL, "Message data is too long\n"); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:58.137455480 +0100 +++ 0013-ipc-handle-more-invalid-parameter-cases.patch 2019-05-08 16:33:57.367579590 +0100 @@ -1 +1 @@ -From 6e5d779ecb9acd034f90af1de8f9416832d663d0 Mon Sep 17 00:00:00 2001 +From 0a784ce51f4fbcb7c0cb9f3875c2082fa52639f1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6e5d779ecb9acd034f90af1de8f9416832d663d0 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org