From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 41EBDA0096 for ; Wed, 8 May 2019 18:03:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 396C8DE3; Wed, 8 May 2019 18:03:11 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9F34834F0 for ; Wed, 8 May 2019 18:03:09 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EC5281E0F; Wed, 8 May 2019 16:03:09 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0706560C82; Wed, 8 May 2019 16:03:07 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Bruce Richardson , dpdk stable Date: Wed, 8 May 2019 17:02:19 +0100 Message-Id: <20190508160233.2648-22-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 08 May 2019 16:03:09 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ring: fix return value check' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/99a6560c9037276ab2cc201d02a4234ce3edde17 Thanks. Kevin Traynor --- >From 99a6560c9037276ab2cc201d02a4234ce3edde17 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 23 Apr 2019 16:23:32 +0100 Subject: [PATCH] net/ring: fix return value check [ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ] 'rte_eth_dev_get_port_by_name()' return value is not checked caught by coverity, adding return value check. Coverity issue: 305853 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- drivers/net/ring/rte_eth_ring.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index bc29795a7..c438da51c 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -397,5 +397,9 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], } - rte_eth_dev_get_port_by_name(ring_name, &port_id); + ret = rte_eth_dev_get_port_by_name(ring_name, &port_id); + if (ret) { + rte_errno = ENODEV; + return -1; + } return port_id; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:58.576476743 +0100 +++ 0022-net-ring-fix-return-value-check.patch 2019-05-08 16:33:57.396578668 +0100 @@ -1 +1 @@ -From e0474b94f8a36672d66be7408e3f7cf00e302329 Mon Sep 17 00:00:00 2001 +From 99a6560c9037276ab2cc201d02a4234ce3edde17 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 979993fd3..ab963a03c 100644 +index bc29795a7..c438da51c 100644