From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 57636A0096 for ; Wed, 8 May 2019 18:03:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E9EEDE3; Wed, 8 May 2019 18:03:14 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1BC2B4CA0 for ; Wed, 8 May 2019 18:03:12 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 847F2300413C; Wed, 8 May 2019 16:03:11 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6E0D60C82; Wed, 8 May 2019 16:03:10 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: dpdk stable Date: Wed, 8 May 2019 17:02:20 +0100 Message-Id: <20190508160233.2648-23-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 08 May 2019 16:03:11 +0000 (UTC) Subject: [dpdk-stable] patch 'net/kni: fix return value check' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/3ec50060a725b0899626eabd9f2512b28471c79a Thanks. Kevin Traynor --- >From 3ec50060a725b0899626eabd9f2512b28471c79a Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 23 Apr 2019 16:36:21 +0100 Subject: [PATCH] net/kni: fix return value check [ upstream commit 994e039b953b06a385d4362e1729a150f1a02d77 ] 'rte_kni_release()' return value is not checked, adding it. Coverity issue: 336837 Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index a1e9970df..9879985ec 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -455,4 +455,5 @@ eth_kni_remove(struct rte_vdev_device *vdev) struct pmd_internals *internals; const char *name; + int ret; name = rte_vdev_device_name(vdev); @@ -473,5 +474,7 @@ eth_kni_remove(struct rte_vdev_device *vdev) internals = eth_dev->data->dev_private; - rte_kni_release(internals->kni); + ret = rte_kni_release(internals->kni); + if (ret) + PMD_LOG(WARNING, "Not able to release kni for %s", name); rte_eth_dev_release_port(eth_dev); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:58.620227926 +0100 +++ 0023-net-kni-fix-return-value-check.patch 2019-05-08 16:33:57.396578668 +0100 @@ -1 +1 @@ -From 994e039b953b06a385d4362e1729a150f1a02d77 Mon Sep 17 00:00:00 2001 +From 3ec50060a725b0899626eabd9f2512b28471c79a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 994e039b953b06a385d4362e1729a150f1a02d77 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 89f44737c..1f232e4da 100644 +index a1e9970df..9879985ec 100644 @@ -21 +22 @@ -@@ -460,4 +460,5 @@ eth_kni_remove(struct rte_vdev_device *vdev) +@@ -455,4 +455,5 @@ eth_kni_remove(struct rte_vdev_device *vdev) @@ -27 +28 @@ -@@ -478,5 +479,7 @@ eth_kni_remove(struct rte_vdev_device *vdev) +@@ -473,5 +474,7 @@ eth_kni_remove(struct rte_vdev_device *vdev)