From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6D1CCA0AD9 for ; Wed, 8 May 2019 18:03:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F4984CA0; Wed, 8 May 2019 18:03:14 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8928D34F0 for ; Wed, 8 May 2019 18:03:13 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0B9310F08; Wed, 8 May 2019 16:03:12 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id E17A560C82; Wed, 8 May 2019 16:03:11 +0000 (UTC) From: Kevin Traynor To: Tiwei Bie Cc: Bernard Iremonger , dpdk stable Date: Wed, 8 May 2019 17:02:21 +0100 Message-Id: <20190508160233.2648-24-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 08 May 2019 16:03:13 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix unintentional integer overflow' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/6361633280b5096991e203e874fd79257dc1a523 Thanks. Kevin Traynor --- >From 6361633280b5096991e203e874fd79257dc1a523 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Wed, 24 Apr 2019 10:29:31 +0800 Subject: [PATCH] app/testpmd: fix unintentional integer overflow [ upstream commit 8efc716f7cadead969e3ca12c0d9ba2f2aa8a8f6 ] Fix the potential overflow in expression 1 << begin by using 1ULL. Coverity issue: 279437, 279445 Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Signed-off-by: Tiwei Bie Acked-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 77641ee23..eeadb2de4 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -17725,5 +17725,5 @@ print_rx_offloads(uint64_t offloads) end = sizeof(offloads) * CHAR_BIT - __builtin_clzll(offloads); - single_offload = 1 << begin; + single_offload = 1ULL << begin; for (bit = begin; bit < end; bit++) { if (offloads & single_offload) @@ -18119,5 +18119,5 @@ print_tx_offloads(uint64_t offloads) end = sizeof(offloads) * CHAR_BIT - __builtin_clzll(offloads); - single_offload = 1 << begin; + single_offload = 1ULL << begin; for (bit = begin; bit < end; bit++) { if (offloads & single_offload) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:58.665889820 +0100 +++ 0024-app-testpmd-fix-unintentional-integer-overflow.patch 2019-05-08 16:33:57.413578128 +0100 @@ -1 +1 @@ -From 8efc716f7cadead969e3ca12c0d9ba2f2aa8a8f6 Mon Sep 17 00:00:00 2001 +From 6361633280b5096991e203e874fd79257dc1a523 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8efc716f7cadead969e3ca12c0d9ba2f2aa8a8f6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 147a617d5..f45ef8a1c 100644 +index 77641ee23..eeadb2de4 100644 @@ -22 +23 @@ -@@ -17834,5 +17834,5 @@ print_rx_offloads(uint64_t offloads) +@@ -17725,5 +17725,5 @@ print_rx_offloads(uint64_t offloads) @@ -29 +30 @@ -@@ -18228,5 +18228,5 @@ print_tx_offloads(uint64_t offloads) +@@ -18119,5 +18119,5 @@ print_tx_offloads(uint64_t offloads)